GNU bug report logs - #58129
29.0.50; [PATCH] Fix (package-update) always install package due to invalid version comparison

Previous Next

Package: emacs;

Reported by: lin Sun <sunlin7 <at> yahoo.com>

Date: Tue, 27 Sep 2022 22:25:02 UTC

Severity: normal

Tags: patch

Found in version 29.0.50

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: lin Sun <sunlin7 <at> yahoo.com>
To: 58129 <at> debbugs.gnu.org
Subject: bug#58129: 29.0.50; [PATCH] Fix (package-update) always install package due to invalid version comparison
Date: Tue, 27 Sep 2022 22:23:53 +0000

[Message part 1 (text/plain, inline)]
The function (package-update) should do nothing if the package already
is the latest one; but it actually always installs the package.

The issue comes from the version comparison in function
(package--updateable-packages).

In function (package--updateable-packages), it will compare the
priority versions for the achieved package and the available package,
but the archived package has NO priority version, and the will get
default 0 as its priority version, then the version comparison gets
wrong results.

This patch will fix the issue, please help to review it. Thanks.

Best Regards
Lin

[0001-Fix-package-update-always-install-package-due-to-inv.patch (text/x-patch, attachment)]
This bug report was last modified 2 years and 239 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.