GNU bug report logs - #58129
29.0.50; [PATCH] Fix (package-update) always install package due to invalid version comparison

Previous Next

Package: emacs;

Reported by: lin Sun <sunlin7 <at> yahoo.com>

Date: Tue, 27 Sep 2022 22:25:02 UTC

Severity: normal

Tags: patch

Found in version 29.0.50

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58129 in the body.
You can then email your comments to 58129 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#58129; Package emacs. (Tue, 27 Sep 2022 22:25:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to lin Sun <sunlin7 <at> yahoo.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Tue, 27 Sep 2022 22:25:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: lin Sun <sunlin7 <at> yahoo.com>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: 29.0.50; [PATCH] Fix (package-update) always install package due to
 invalid version comparison
Date: Tue, 27 Sep 2022 22:23:53 +0000

[Message part 1 (text/plain, inline)]
The function (package-update) should do nothing if the package already
is the latest one; but it actually always installs the package.

The issue comes from the version comparison in function
(package--updateable-packages).

In function (package--updateable-packages), it will compare the
priority versions for the achieved package and the available package,
but the archived package has NO priority version, and the will get
default 0 as its priority version, then the version comparison gets
wrong results.

This patch will fix the issue, please help to review it. Thanks.

Best Regards
Lin

[0001-Fix-package-update-always-install-package-due-to-inv.patch (text/x-patch, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#58129; Package emacs. (Wed, 28 Sep 2022 11:06:02 GMT) Full text and rfc822 format available.

Message #8 received at 58129 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: lin Sun <sunlin7 <at> yahoo.com>
Cc: 58129 <at> debbugs.gnu.org
Subject: Re: bug#58129: 29.0.50; [PATCH] Fix (package-update) always install
 package due to invalid version comparison
Date: Wed, 28 Sep 2022 13:05:43 +0200

lin Sun <sunlin7 <at> yahoo.com> writes:

> This patch will fix the issue, please help to review it. Thanks.

Thanks; pushed to Emacs 29.
bug marked as fixed in version 29.1, send any further explanations to 58129 <at> debbugs.gnu.org and lin Sun <sunlin7 <at> yahoo.com> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Wed, 28 Sep 2022 11:06:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 26 Oct 2022 11:24:10 GMT) Full text and rfc822 format available.
This bug report was last modified 2 years and 239 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.