GNU bug report logs - #57876
[PATCH] pulse-momentary-highlight-one-line: Act on visual line

Previous Next

Full log

View this message in rfc822 format

From: Augusto Stoffel <arstoffel <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: public <at> protesilaos.com, 57876 <at> debbugs.gnu.org
Subject: bug#57876: [PATCH] pulse-momentary-highlight-one-line: Act on visual line
Date: Sat, 17 Sep 2022 12:56:44 +0200

On Sat, 17 Sep 2022 at 12:38, Eli Zaretskii wrote:

>> Cc: Protesilaos Stavrou <public <at> protesilaos.com>
>> From: Augusto Stoffel <arstoffel <at> gmail.com>
>> Date: Sat, 17 Sep 2022 10:23:01 +0200
>> 
>> Tags: patch
>> 
>> Currently, if point is say at the prompt of a comint buffer,
>> pulse-momentary-highlight-one-line doesn't show do anything – or, more
>> precisely, it pulses the zero-length region from prompt end to EOB.
>> 
>> Prot: I think you want to apply a similar change in pulsar.el.
>> 
>> 
>> >From e1241510fc9e0deddc5adb416aec5de4ca0300c8 Mon Sep 17 00:00:00 2001
>> From: Augusto Stoffel <arstoffel <at> gmail.com>
>> Date: Sat, 17 Sep 2022 10:17:34 +0200
>> Subject: [PATCH] pulse-momentary-highlight-one-line: Act on visual line
>> 
>> * lisp/cedet/pulse.el (pulse-momentary-highlight-one-line):  Act on
>> entire visual line, ignoring fields etc.
>
> Why don't you use beginning/end-of-visual-line?

Because it obeys fields, so if you try to highlight a prompt line in a
comint buffer, only part of the line would be highlighted.

The (only, AFAICT) purpose of pulse-momentary-highlight-one-line is to
locate the cursor, so you want to pulse a little rectangle spanning the
entire width of the window.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.