GNU bug report logs - #57876
[PATCH] pulse-momentary-highlight-one-line: Act on visual line

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 57876 in the body.
You can then email your comments to 57876 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Augusto Stoffel <arstoffel <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] pulse-momentary-highlight-one-line: Act on visual line
Date: Sat, 17 Sep 2022 10:23:01 +0200

[Message part 1 (text/plain, inline)]

Tags: patch

Currently, if point is say at the prompt of a comint buffer,
pulse-momentary-highlight-one-line doesn't show do anything – or, more
precisely, it pulses the zero-length region from prompt end to EOB.

Prot: I think you want to apply a similar change in pulsar.el.

[0001-pulse-momentary-highlight-one-line-Act-on-visual-lin.patch (text/patch, attachment)]

Message #8 received at 57876 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Augusto Stoffel <arstoffel <at> gmail.com>
Cc: public <at> protesilaos.com, 57876 <at> debbugs.gnu.org
Subject: Re: bug#57876: [PATCH] pulse-momentary-highlight-one-line: Act on
 visual line
Date: Sat, 17 Sep 2022 12:38:15 +0300

> Cc: Protesilaos Stavrou <public <at> protesilaos.com>
> From: Augusto Stoffel <arstoffel <at> gmail.com>
> Date: Sat, 17 Sep 2022 10:23:01 +0200
> 
> Tags: patch
> 
> Currently, if point is say at the prompt of a comint buffer,
> pulse-momentary-highlight-one-line doesn't show do anything – or, more
> precisely, it pulses the zero-length region from prompt end to EOB.
> 
> Prot: I think you want to apply a similar change in pulsar.el.
> 
> 
> >From e1241510fc9e0deddc5adb416aec5de4ca0300c8 Mon Sep 17 00:00:00 2001
> From: Augusto Stoffel <arstoffel <at> gmail.com>
> Date: Sat, 17 Sep 2022 10:17:34 +0200
> Subject: [PATCH] pulse-momentary-highlight-one-line: Act on visual line
> 
> * lisp/cedet/pulse.el (pulse-momentary-highlight-one-line):  Act on
> entire visual line, ignoring fields etc.

Why don't you use beginning/end-of-visual-line?

Message #11 received at 57876 <at> debbugs.gnu.org (full text, mbox):

From: Augusto Stoffel <arstoffel <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: public <at> protesilaos.com, 57876 <at> debbugs.gnu.org
Subject: Re: bug#57876: [PATCH] pulse-momentary-highlight-one-line: Act on
 visual line
Date: Sat, 17 Sep 2022 12:56:44 +0200

On Sat, 17 Sep 2022 at 12:38, Eli Zaretskii wrote:

>> Cc: Protesilaos Stavrou <public <at> protesilaos.com>
>> From: Augusto Stoffel <arstoffel <at> gmail.com>
>> Date: Sat, 17 Sep 2022 10:23:01 +0200
>> 
>> Tags: patch
>> 
>> Currently, if point is say at the prompt of a comint buffer,
>> pulse-momentary-highlight-one-line doesn't show do anything – or, more
>> precisely, it pulses the zero-length region from prompt end to EOB.
>> 
>> Prot: I think you want to apply a similar change in pulsar.el.
>> 
>> 
>> >From e1241510fc9e0deddc5adb416aec5de4ca0300c8 Mon Sep 17 00:00:00 2001
>> From: Augusto Stoffel <arstoffel <at> gmail.com>
>> Date: Sat, 17 Sep 2022 10:17:34 +0200
>> Subject: [PATCH] pulse-momentary-highlight-one-line: Act on visual line
>> 
>> * lisp/cedet/pulse.el (pulse-momentary-highlight-one-line):  Act on
>> entire visual line, ignoring fields etc.
>
> Why don't you use beginning/end-of-visual-line?

Because it obeys fields, so if you try to highlight a prompt line in a
comint buffer, only part of the line would be highlighted.

The (only, AFAICT) purpose of pulse-momentary-highlight-one-line is to
locate the cursor, so you want to pulse a little rectangle spanning the
entire width of the window.

Message #14 received at 57876 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Augusto Stoffel <arstoffel <at> gmail.com>
Cc: public <at> protesilaos.com, 57876 <at> debbugs.gnu.org
Subject: Re: bug#57876: [PATCH] pulse-momentary-highlight-one-line: Act on
 visual line
Date: Sat, 17 Sep 2022 14:20:43 +0300

> From: Augusto Stoffel <arstoffel <at> gmail.com>
> Cc: 57876 <at> debbugs.gnu.org,  public <at> protesilaos.com
> Date: Sat, 17 Sep 2022 12:56:44 +0200
> 
> > Why don't you use beginning/end-of-visual-line?
> 
> Because it obeys fields, so if you try to highlight a prompt line in a
> comint buffer, only part of the line would be highlighted.

It should be possible to disable fields temporarily by binding
inhibit-point-motion-hooks, right?  I prefer doing that to reinventing
the wheel of moving to the edges of the visible line.

Message #17 received at 57876 <at> debbugs.gnu.org (full text, mbox):

From: Augusto Stoffel <arstoffel <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: public <at> protesilaos.com, 57876 <at> debbugs.gnu.org
Subject: Re: bug#57876: [PATCH] pulse-momentary-highlight-one-line: Act on
 visual line
Date: Sat, 17 Sep 2022 13:31:55 +0200

On Sat, 17 Sep 2022 at 14:20, Eli Zaretskii wrote:

>> From: Augusto Stoffel <arstoffel <at> gmail.com>
>> Cc: 57876 <at> debbugs.gnu.org,  public <at> protesilaos.com
>> Date: Sat, 17 Sep 2022 12:56:44 +0200
>> 
>> > Why don't you use beginning/end-of-visual-line?
>> 
>> Because it obeys fields, so if you try to highlight a prompt line in a
>> comint buffer, only part of the line would be highlighted.
>
> It should be possible to disable fields temporarily by binding
> inhibit-point-motion-hooks, right?  I prefer doing that to reinventing
> the wheel of moving to the edges of the visible line.

This variable is allegedly obsolete since Emacs 25.  In any case, the
patch is really trivial, so how would this be making the code simpler or
more robust?

Message #20 received at 57876 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Augusto Stoffel <arstoffel <at> gmail.com>
Cc: public <at> protesilaos.com, 57876 <at> debbugs.gnu.org
Subject: Re: bug#57876: [PATCH] pulse-momentary-highlight-one-line: Act on
 visual line
Date: Sat, 17 Sep 2022 14:49:44 +0300

> From: Augusto Stoffel <arstoffel <at> gmail.com>
> Cc: 57876 <at> debbugs.gnu.org,  public <at> protesilaos.com
> Date: Sat, 17 Sep 2022 13:31:55 +0200
> 
> > It should be possible to disable fields temporarily by binding
> > inhibit-point-motion-hooks, right?  I prefer doing that to reinventing
> > the wheel of moving to the edges of the visible line.
> 
> This variable is allegedly obsolete since Emacs 25.

Sorry, I meant inhibit-field-text-motion.

> In any case, the patch is really trivial, so how would this be
> making the code simpler or more robust?

I just explained the reasons above: we have these utility functions
for a reason: so that Lisp programs won't need to reinvent how to do
what these utilities do every time.

Message #23 received at 57876 <at> debbugs.gnu.org (full text, mbox):

From: Protesilaos Stavrou <public <at> protesilaos.com>
To: Augusto Stoffel <arstoffel <at> gmail.com>, 57876 <at> debbugs.gnu.org
Subject: Re: bug#57876: [PATCH] pulse-momentary-highlight-one-line: Act on
 visual line
Date: Sun, 18 Sep 2022 10:23:53 +0300

> From: Augusto Stoffel <arstoffel <at> gmail.com>
> Date: Sat, 17 Sep 2022 10:23:01 +0200
>
> Tags: patch
>
> Currently, if point is say at the prompt of a comint buffer,
> pulse-momentary-highlight-one-line doesn't show do anything – or, more
> precisely, it pulses the zero-length region from prompt end to EOB.
>
> Prot: I think you want to apply a similar change in pulsar.el.

Hello Augusto,

Just to note that I am monitoring this thread and will act accordingly.

Thank you!

Prot

-- 
Protesilaos Stavrou
https://protesilaos.com

Message #26 received at 57876 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Augusto Stoffel <arstoffel <at> gmail.com>
Cc: Protesilaos Stavrou <public <at> protesilaos.com>, 57876 <at> debbugs.gnu.org
Subject: Re: bug#57876: [PATCH] pulse-momentary-highlight-one-line: Act on
 visual line
Date: Sun, 18 Sep 2022 13:02:11 +0200

Augusto Stoffel <arstoffel <at> gmail.com> writes:

> Currently, if point is say at the prompt of a comint buffer,
> pulse-momentary-highlight-one-line doesn't show do anything – or, more
> precisely, it pulses the zero-length region from prompt end to EOB.

Thanks; pushed to Emacs 29.

Eli Zaretskii <eliz <at> gnu.org> writes:

>> This variable is allegedly obsolete since Emacs 25.
>
> Sorry, I meant inhibit-field-text-motion.

That variable does not affect what beginning-of-visual-line does
w.r.t. fields, only invisible text.

Message #31 received at 57876 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 57876 <at> debbugs.gnu.org, public <at> protesilaos.com, arstoffel <at> gmail.com
Subject: Re: bug#57876: [PATCH] pulse-momentary-highlight-one-line: Act on
 visual line
Date: Sun, 18 Sep 2022 15:40:36 +0300

> Cc: Protesilaos Stavrou <public <at> protesilaos.com>, 57876 <at> debbugs.gnu.org
> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Date: Sun, 18 Sep 2022 13:02:11 +0200
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >> This variable is allegedly obsolete since Emacs 25.
> >
> > Sorry, I meant inhibit-field-text-motion.
> 
> That variable does not affect what beginning-of-visual-line does
> w.r.t. fields, only invisible text.

That's not what the doc string of inhibit-field-text-motion does, so
it might be a bug in itself.  line-beginning-position, for example,
does ignore fields when that variable is non-nil.

Message #34 received at 57876 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 57876 <at> debbugs.gnu.org, public <at> protesilaos.com, arstoffel <at> gmail.com
Subject: Re: bug#57876: [PATCH] pulse-momentary-highlight-one-line: Act on
 visual line
Date: Sun, 18 Sep 2022 14:45:33 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

>> >> This variable is allegedly obsolete since Emacs 25.
>> >
>> > Sorry, I meant inhibit-field-text-motion.
>> 
>> That variable does not affect what beginning-of-visual-line does
>> w.r.t. fields, only invisible text.
>
> That's not what the doc string of inhibit-field-text-motion does, so
> it might be a bug in itself.  line-beginning-position, for example,
> does ignore fields when that variable is non-nil.

Oh, sorry!  I was confusing myself by testing with

(let ((inhibit-point-motion-hooks t)) (beginning-of-visual-line))

which is the wrong thing, of course -- with inhibit-field-text-motion it
works fine.

So adjusting the patch to use that instead might be appropriate (but
doesn't make much difference).

Message #37 received at 57876 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 57876 <at> debbugs.gnu.org, public <at> protesilaos.com, arstoffel <at> gmail.com
Subject: Re: bug#57876: [PATCH] pulse-momentary-highlight-one-line: Act on
 visual line
Date: Sun, 18 Sep 2022 15:55:48 +0300

> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Cc: arstoffel <at> gmail.com,  public <at> protesilaos.com,  57876 <at> debbugs.gnu.org
> Date: Sun, 18 Sep 2022 14:45:33 +0200
> 
> Oh, sorry!  I was confusing myself by testing with
> 
> (let ((inhibit-point-motion-hooks t)) (beginning-of-visual-line))
> 
> which is the wrong thing, of course -- with inhibit-field-text-motion it
> works fine.
> 
> So adjusting the patch to use that instead might be appropriate (but
> doesn't make much difference).

My point in suggesting that was that it is better to use utility
functions we have rather than the equivalent code, because the utility
functions presumably serve as a locus of all our wisdom related to
what they do.  For example, what does "beginning of visual line" mean
with bidirectional text?  Instead of having to decide this in each
case, we have a function that already does TRT.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.