GNU bug report logs - #57636
[PATCH] Recognize zstandard (.zst) suffix in lisp/info.el

Previous Next

Package: emacs;

Reported by: Sam James <sam <at> gentoo.org>

Date: Wed, 7 Sep 2022 04:02:01 UTC

Severity: normal

Tags: moreinfo, patch

Merged with 57665

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #13 received at 57636 <at> debbugs.gnu.org (full text, mbox):

From: Sam James <sam <at> gentoo.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 57636 <at> debbugs.gnu.org
Subject: Re: bug#57636: [PATCH] Recognize zstandard (.zst) suffix in
 lisp/info.el
Date: Thu, 8 Sep 2022 03:10:21 +0100
[Message part 1 (text/plain, inline)]

> On 7 Sep 2022, at 12:35, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
>> Cc: Sam James <sam <at> gentoo.org>
>> From: Sam James <sam <at> gentoo.org>
>> Date: Wed,  7 Sep 2022 05:00:40 +0100
>> 
>> * lisp/info.el (Info-suffix-list): Recognize .zst file extension from the
>> zstd compression tool. This allos reading Info pages compressed with zstandard.
>> ---
>> lisp/info.el | 4 ++++
>> 1 file changed, 4 insertions(+)
>> 
>> diff --git a/lisp/info.el b/lisp/info.el
>> index 1a58910c3a..fdbe1f9b90 100644
>> --- a/lisp/info.el
>> +++ b/lisp/info.el
>> @@ -451,6 +451,7 @@ or `Info-virtual-nodes'."
>>        (".info.z"    . "gunzip")
>>        (".info.bz2"  . ("bzip2" "-dc"))
>>        (".info.xz"   . "unxz")
>> +       (".info.zst"  . ("unzstd" "--rm" "-q"))
> 
> Thanks, but I don't think I understand the --rm part: these commands
> aren't supposed to replace the original compressed file with its
> decompressed version, they are supposed to write the decompressed text
> to stdout, where it will be read by Emacs and displayed, and leave the
> original compressed files alone.
> 
> So I think you want "-dc", not "--rm -q".  Am I missing something?

You're missing nothing and you're exactly right. Apologies
tor the error -- that seems obvious now!

I'll send a fixed version shortly.
[signature.asc (application/pgp-signature, attachment)]

This bug report was last modified 2 years and 256 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.