GNU bug report logs - #57635
29.0.50; Look into using generator.el's CPS machinery to replace 'eshell-do-eval'

Previous Next

To reply to this bug, email your comments to 57635 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; Look into using generator.el's CPS machinery to replace
 'eshell-do-eval'
Date: Tue, 6 Sep 2022 20:58:00 -0700

In order to make long-running Eshell commands behave more-nicely, Eshell 
uses iterative evaluation of many commands so that it can return control 
back to the rest of Emacs. This has a lot of similarity to how 
generator.el works.

This would hopefully help prevent obscure bugs in Eshell, such as 
bug#54190. In that bug, Stefan mentions[1]:

> Looks like a bug somewhere in the `eshell-do-eval` machinery, yes.
> Until we find the problem (or rewrite `eshell-do-eval` on top of the CPS
> converter of `generator.el`), I think reverting this change (and adding
> a comment pointing to this bug) sounds like a great plan.

[1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54190#17

Message #8 received at 57635 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: 57635 <at> debbugs.gnu.org
Subject: Re: bug#57635: 29.0.50; Look into using generator.el's CPS
 machinery to replace 'eshell-do-eval'
Date: Wed, 07 Sep 2022 08:45:52 -0400

> In order to make long-running Eshell commands behave more-nicely, Eshell
> uses iterative evaluation of many commands so that it can return control
> back to the rest of Emacs. This has a lot of similarity to how
> generator.el works.

Indeed, the idea would be to replace the commands that launch processes
with "yields" to an external loop (that just launches the next process
and then calls the generator again).


        Stefan

Message #11 received at 57635 <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 57635 <at> debbugs.gnu.org
Subject: Re: bug#57635: 29.0.50; Look into using generator.el's CPS machinery
 to replace 'eshell-do-eval'
Date: Sun, 11 Sep 2022 18:01:04 -0700

On 9/7/2022 5:45 AM, Stefan Monnier via Bug reports for GNU Emacs, the 
Swiss army knife of text editors wrote:
> Indeed, the idea would be to replace the commands that launch processes
> with "yields" to an external loop (that just launches the next process
> and then calls the generator again).

That part should be fairly straightforward; there's already 
'eshell-eval-command' and friends ('eshell-resume-command', 
'eshell-resume-eval', and 'eshell-do-eval'), which work pretty much like 
this already. Looking through this, I see a few main differences between 
how Eshell does things and how generator.el does things:

----------------------------------------

1) Eshell uses (throw 'eshell-defer) to yield

This is probably easy to fix, since it's only used in a couple places, 
and it looks like it's purely an implementation detail.

2) Eshell doesn't have anything like 'iter-defun'

Eshell just evaluates a Lisp form directly (you can see this by tracing 
'eshell-eval-command' and then running some external process in Eshell). 
I'm not sure how hard it would be to get generator.el to be ok with this.

3) Eshell allows replacing a form by throwing 'eshell-replace-command'

This is the trickiest part (to me, anyway). It's typically used by 
Eshell built-in commands when they want to give up and run an external 
process, though it can be used for a bunch of other things. I'm not sure 
what the best way to handle this via generator.el would be. Is there any 
straightforward way to do this?

----------------------------------------

If anyone has ideas, I'm all ears. This is pretty far down into the 
weeds of Lisp metaprogramming, so I'm just making some educated guesses 
here. I think doing this would be a big improvement for Eshell though, 
since I've already bumped up against a few cases that really look like 
they're just bugs in 'eshell-do-eval'. Moving to generator.el would 
hopefully fix those and make Eshell easier to maintain/improve.

Message #16 received at 57635 <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 57635 <at> debbugs.gnu.org
Subject: Re: bug#57635: 29.0.50; Look into using generator.el's CPS machinery
 to replace 'eshell-do-eval'
Date: Thu, 15 Dec 2022 17:10:35 -0800

On 9/7/2022 5:45 AM, Stefan Monnier via Bug reports for GNU Emacs, the 
Swiss army knife of text editors wrote:
>> In order to make long-running Eshell commands behave more-nicely, Eshell
>> uses iterative evaluation of many commands so that it can return control
>> back to the rest of Emacs. This has a lot of similarity to how
>> generator.el works.
> 
> Indeed, the idea would be to replace the commands that launch processes
> with "yields" to an external loop (that just launches the next process
> and then calls the generator again).

Maybe an even better solution would be to use Emacs threads. This should 
do everything that Eshell needs, plus hopefully add the ability to add 
some basic job control as well. (Well, one day...)

I hacked something up that seems to work for simple cases, and it 
shouldn't be *too* hard to get it working more generally. This will be a 
big change for Eshell, so it might make sense to create a feature branch 
when I have a little more to show. However, I can already see how this 
will eliminate the need for a number of workarounds in Eshell's command 
invocation logic.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.