GNU bug report logs - #57493
<user-account> should allow for customizing home directory permission bits

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Josselin Poiret <dev <at> jpoiret.xyz>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#57493: closed (<user-account> should allow for customizing
 home directory permission bits)
Date: Fri, 25 Aug 2023 16:33:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 25 Aug 2023 18:32:24 +0200
with message-id <87ledzt753.fsf <at> jpoiret.xyz>
and subject line Re: bug#57493: [EXT] Re: bug#57493: <user-account> should allow for customizing home directory permission bits
has caused the debbugs.gnu.org bug report #57493,
regarding <user-account> should allow for customizing home directory permission bits
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
57493: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=57493
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: "Thompson, David" <dthompson2 <at> worcester.edu>
To: bug-guix <at> gnu.org
Subject: <user-account> should allow for customizing home directory permission
 bits
Date: Tue, 30 Aug 2022 12:53:26 -0400

[Message part 3 (text/plain, inline)]

Hi Guix,

Issue 56444 (https://issues.guix.gnu.org/56444) was caused by the
activate-users+groups procedure in (gnu build activation) unconditionally
setting all user home directory permission bits to 700. The fix for that
bug was to set the bits for a particular user to 750 in a service
activation script.  The fix is quite imperfect, however, because during
system reconfiguration the bits are temporarily reset back to 700 by
activate-users+groups, breaking Guix's promise of atomicity.  The proper
fix would be to add something like a 'home-directory-permission-bits' field
to <user-account>, which defaults to 700, and have activate-users+groups
use that value.  This way, there will no longer be an unknown amount of
time where the bits are reset and potentially breaking some service during
that time.

It seems that there is already some support for implementing such a change
and I am happy to do the work, but I wanted to ask: Are there any gotchas
or issues I should be aware of?  It seems straightforward to me but I
haven't made modifications to the system code in years. I don't want to be
the reason 'guix system reconfigure' fails for someone. :)

Thanks,

- Dave

[Message part 4 (text/html, inline)]

[Message part 5 (message/rfc822, inline)]

From: Josselin Poiret <dev <at> jpoiret.xyz>
To: "Thompson, David" <dthompson2 <at> worcester.edu>, Liliana Marie Prikler
 <liliana.prikler <at> gmail.com>
Cc: 57493-done <at> debbugs.gnu.org
Subject: Re: bug#57493: [EXT] Re: bug#57493: <user-account> should allow for
 customizing home directory permission bits
Date: Fri, 25 Aug 2023 18:32:24 +0200

[Message part 6 (text/plain, inline)]

Hi Dave,

Pushed as e9a5eebc785cb843034b38c5c5a6dd10904bdf2a.

Thanks for your contribution!  Closing.

Best,
-- 
Josselin Poiret

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.