GNU bug report logs - #57492
[PATCH core-updates] gnu: boost: Update to 1.80.0.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 57492 in the body.
You can then email your comments to 57492 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Greg Hogan <code <at> greghogan.com>
To: guix-patches <at> gnu.org
Cc: Greg Hogan <code <at> greghogan.com>
Subject: [PATCH core-updates] gnu: boost: Update to 1.80.0.
Date: Tue, 30 Aug 2022 16:36:24 +0000

* gnu/packages/boost.scm (boost): Update to 1.80.0.
[source](patches): Add new and remove old upstream patches.
---
 gnu/packages/boost.scm | 26 ++++++++++++++++++++------
 1 file changed, 20 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/boost.scm b/gnu/packages/boost.scm
index 818669b757..55296889b8 100644
--- a/gnu/packages/boost.scm
+++ b/gnu/packages/boost.scm
@@ -68,7 +68,7 @@ (define (boost-patch name version hash)
 (define-public boost
   (package
     (name "boost")
-    (version "1.79.0")
+    (version "1.80.0")
     (source (origin
               (method url-fetch)
               (uri (string-append "https://boostorg.jfrog.io/artifactory/main/release/"
@@ -76,13 +76,27 @@ (define-public boost
                                   (version-with-underscores version) ".tar.bz2"))
               (patches
                (list (boost-patch
-                      ;; 1.79.0 was released with a segmentation fault:
-                      ;; <https://github.com/boostorg/json/issues/692>.
-                      "0001-json-array-erase-relocate.patch" version
-                      "1b0izwj8w92imr8ydzrh522syncprpf82n3kcy6apxn6p54b7p0f")))
+                      ;; Boost.Filesystem directory iterators may fail to
+                      ;; construct for a network share on Windows prior to 10:
+                      ;; https://github.com/boostorg/filesystem/pull/246,
+                      ;; https://github.com/boostorg/filesystem/issues/245
+                      "0001-filesystem-win-fix-dir-it-net-share.patch" version
+                      "067hhylqkzzdbqzc1hkbpaqmvz248lxqrdhb2yi6iq9qabsik3lk")
+                     (boost-patch
+                      ;; In Boost.Filesystem on Windows, weakly_canonical fails
+                      ;; to process paths that start with the "\\?\" prefix:
+                      ;; https://github.com/boostorg/filesystem/issues/247
+                      "0002-filesystem-fix-weakly-canonical-long-paths.patch" version
+                      "00w3albf8527glclx85p5b2ml3vr06xpwwmfyzg005v1cp8avcpi")
+                     (boost-patch
+                      ;; Boost.Unordered containers are not in a valid state
+                      ;; after moving:
+                      ;; https://github.com/boostorg/unordered/issues/139
+                      "0003-unordered-valid-after-move.patch" version
+                      "0dw839w22cawqawfpsx7j7v9y0x2vn66m732iidpxvdxbjn2kzva")))
               (sha256
                (base32
-                "0fggarccddj6q4ifj3kn7g565rbhn4ia1vd45fxb7y57a6fmhpa7"))))
+                "1h00qp4z5k6lfz310xjwsmqs8fwxi6ngas51169cafz4h9fmc68y"))))
     (build-system gnu-build-system)
     (inputs
      (append
-- 
2.37.2

Message #8 received at 57492 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Greg Hogan <code <at> greghogan.com>, 57492 <at> debbugs.gnu.org
Subject: Re: [bug#57492] [PATCH core-updates] gnu: boost: Update to 1.80.0.
Date: Tue, 30 Aug 2022 21:50:47 +0200

[Message part 1 (text/plain, inline)]

On 30-08-2022 18:36, Greg Hogan wrote:

> +                      ;; Boost.Filesystem directory iterators may fail to
> +                      ;; construct for a network share on Windows prior to 10:
> +                      ;;https://github.com/boostorg/filesystem/pull/246,
> +                      ;;https://github.com/boostorg/filesystem/issues/245
> +                      "0001-filesystem-win-fix-dir-it-net-share.patch" version
> +                      "067hhylqkzzdbqzc1hkbpaqmvz248lxqrdhb2yi6iq9qabsik3lk")
> +                     (boost-patch
> +                      ;; In Boost.Filesystem on Windows, weakly_canonical fails
> +                      ;; to process paths that start with the "\\?\" prefix:
> +                      ;;https://github.com/boostorg/filesystem/issues/247
> +                      "0002-filesystem-fix-weakly-canonical-long-paths.patch" version
> +                      "00w3albf8527glclx85p5b2ml3vr06xpwwmfyzg005v1cp8avcpi")

Going by https://www.boost.org/patches/, you seem to have missed 
0004-filesystem-posix-fix-no-at-apis-missing-include.patch. Perhaps it 
is not required for compilation on supported targets in Guix, but 
neither is Windows a supported target yet you are including 
Windows-specific patches.

Greetings,
Maxime

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #11 received at 57492 <at> debbugs.gnu.org (full text, mbox):

From: Greg Hogan <code <at> greghogan.com>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 57492 <at> debbugs.gnu.org
Subject: Re: [bug#57492] [PATCH core-updates] gnu: boost: Update to 1.80.0.
Date: Tue, 30 Aug 2022 16:15:26 -0400

On Tue, Aug 30, 2022 at 3:50 PM Maxime Devos <maximedevos <at> telenet.be> wrote:
> [...]
> Going by https://www.boost.org/patches/, you seem to have missed
> 0004-filesystem-posix-fix-no-at-apis-missing-include.patch. Perhaps it
> is not required for compilation on supported targets in Guix, but
> neither is Windows a supported target yet you are including
> Windows-specific patches.
>
> Greetings,
> Maxime

Thank you, this fourth patch was missed as it is absent from the
release page at
https://www.boost.org/users/history/version_1_80_0.html. I will submit
a revised patch and also check the full patch listing in the future.

Greg

Message #14 received at 57492 <at> debbugs.gnu.org (full text, mbox):

From: Greg Hogan <code <at> greghogan.com>
To: 57492 <at> debbugs.gnu.org
Cc: Greg Hogan <code <at> greghogan.com>
Subject: [PATCH core-updates v2] gnu: boost: Update to 1.80.0.
Date: Wed, 31 Aug 2022 13:43:25 +0000

* gnu/packages/boost.scm (boost): Update to 1.80.0.
[source](patches): Add new and remove old upstream patches.
---
 gnu/packages/boost.scm | 32 ++++++++++++++++++++++++++------
 1 file changed, 26 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/boost.scm b/gnu/packages/boost.scm
index 818669b757..d2b676cc73 100644
--- a/gnu/packages/boost.scm
+++ b/gnu/packages/boost.scm
@@ -68,7 +68,7 @@ (define (boost-patch name version hash)
 (define-public boost
   (package
     (name "boost")
-    (version "1.79.0")
+    (version "1.80.0")
     (source (origin
               (method url-fetch)
               (uri (string-append "https://boostorg.jfrog.io/artifactory/main/release/"
@@ -76,13 +76,33 @@ (define-public boost
                                   (version-with-underscores version) ".tar.bz2"))
               (patches
                (list (boost-patch
-                      ;; 1.79.0 was released with a segmentation fault:
-                      ;; <https://github.com/boostorg/json/issues/692>.
-                      "0001-json-array-erase-relocate.patch" version
-                      "1b0izwj8w92imr8ydzrh522syncprpf82n3kcy6apxn6p54b7p0f")))
+                      ;; Boost.Filesystem directory iterators may fail to
+                      ;; construct for a network share on Windows prior to 10:
+                      ;; https://github.com/boostorg/filesystem/pull/246,
+                      ;; https://github.com/boostorg/filesystem/issues/245
+                      "0001-filesystem-win-fix-dir-it-net-share.patch" version
+                      "067hhylqkzzdbqzc1hkbpaqmvz248lxqrdhb2yi6iq9qabsik3lk")
+                     (boost-patch
+                      ;; In Boost.Filesystem on Windows, weakly_canonical fails
+                      ;; to process paths that start with the "\\?\" prefix:
+                      ;; https://github.com/boostorg/filesystem/issues/247
+                      "0002-filesystem-fix-weakly-canonical-long-paths.patch" version
+                      "00w3albf8527glclx85p5b2ml3vr06xpwwmfyzg005v1cp8avcpi")
+                     (boost-patch
+                      ;; Boost.Unordered containers are not in a valid state
+                      ;; after moving:
+                      ;; https://github.com/boostorg/unordered/issues/139
+                      "0003-unordered-valid-after-move.patch" version
+                      "0dw839w22cawqawfpsx7j7v9y0x2vn66m732iidpxvdxbjn2kzva")
+                     (boost-patch
+                      ;; Fixed a missing include on POSIX systems that don't
+                      ;; support *at APIs:
+                      ;; https://github.com/boostorg/filesystem/issues/250
+                      "0004-filesystem-posix-fix-no-at-apis-missing-include.patch" version
+                      "09k8k3b1306jkjls12wfghj820n828j6aaxzmcr0wpnjhp8fzi1v")))
               (sha256
                (base32
-                "0fggarccddj6q4ifj3kn7g565rbhn4ia1vd45fxb7y57a6fmhpa7"))))
+                "1h00qp4z5k6lfz310xjwsmqs8fwxi6ngas51169cafz4h9fmc68y"))))
     (build-system gnu-build-system)
     (inputs
      (append
-- 
2.37.2

Message #19 received at 57492-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: Greg Hogan <code <at> greghogan.com>, 57492-done <at> debbugs.gnu.org
Cc: Greg Hogan <code <at> greghogan.com>
Subject: Re: [bug#57492] [PATCH core-updates v2] gnu: boost: Update to 1.80.0.
Date: Thu, 01 Sep 2022 23:00:21 +0200

[Message part 1 (text/plain, inline)]

Greg Hogan <code <at> greghogan.com> skriver:

> * gnu/packages/boost.scm (boost): Update to 1.80.0.
> [source](patches): Add new and remove old upstream patches.

Applied, thanks!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.