GNU bug report logs - #5747
24.0.50; Unstable C-mode indentation

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 5747 in the body.
You can then email your comments to 5747 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ari Roponen <ari.roponen <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.50; Unstable C-mode indentation
Date: Sun, 21 Mar 2010 14:48:34 +0200

Hi, the indentation of C-mode is not stable. Here is the recipe
to reproduce the problem:

1. Eval this form in "emacs -Q":

  (progn
    (switch-to-buffer "tmp.c")
    (erase-buffer)
    (c-mode)
    (insert "int fun (void)\n{\n    int a = foo ();\n}")
    (c-indent-line-or-region)
    (backward-sexp)
    (c-indent-line-or-region))

2. Now every time you press TAB-key the indentation of the
bracket alternates between two positions.


By bisecting the source (using the GIT-repo) I found that the
problem comes from:

  acm <at> muc.de-20091203160210-5u4g9gppsv3zts3e

committer: Alan Mackenzie <acm <at> muc.de>
timestamp: Thu 2009-12-03 16:02:10 +0000
message:
  Enhance `c-parse-state' to run efficiently in "brace desserts".


After reverting that the problem goes away.


In GNU Emacs 24.0.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.19.7)
 of 2010-03-18 on arirop
Windowing system distributor `Fedora Project', version 11.0.10799901

-- 
Ari Roponen

Message #8 received at 5747 <at> debbugs.gnu.org (full text, mbox):

From: Alan Mackenzie <acm <at> muc.de>
To: Ari Roponen <ari.roponen <at> gmail.com>
Cc: Chong Yidong <cyd <at> stupidchicken.com>, Michael Welsh Duggan <md5i <at> md5i.com>,
	Jan Djärv <jan.h.d <at> swipnet.se>,
	5747 <at> debbugs.gnu.org, Paul Pogonyshev <pogonyshev <at> gmx.net>
Subject: Re: bug#5747: 24.0.50; Unstable C-mode indentation
Date: Mon, 22 Mar 2010 11:36:31 +0000

Hi, Ari and everybody else!

On Sun, Mar 21, 2010 at 02:48:34PM +0200, Ari Roponen wrote:
> Hi, the indentation of C-mode is not stable. Here is the recipe
> to reproduce the problem:

> 1. Eval this form in "emacs -Q":

>   (progn
>     (switch-to-buffer "tmp.c")
>     (erase-buffer)
>     (c-mode)
>     (insert "int fun (void)\n{\n    int a = foo ();\n}")
>     (c-indent-line-or-region)
>     (backward-sexp)
>     (c-indent-line-or-region))

> 2. Now every time you press TAB-key the indentation of the
> bracket alternates between two positions.


> By bisecting the source (using the GIT-repo) I found that the
> problem comes from:

>   acm <at> muc.de-20091203160210-5u4g9gppsv3zts3e

> committer: Alan Mackenzie <acm <at> muc.de>
> timestamp: Thu 2009-12-03 16:02:10 +0000
> message:
>   Enhance `c-parse-state' to run efficiently in "brace desserts".


> After reverting that the problem goes away.

That is one absolutely tremendous bug report!  Thank you very much indeed
for it!  With all the information you've given me, I was able to track
down an off-by-one error very quickly.

Would you please (all) try the following patch, which I'm hopeful will
fix all the recent instabilities in CC Modes indentation.


*** cc-engine.el~	2010-03-22 11:15:40.248931952 +0000
--- cc-engine.el	2010-03-22 11:24:04.981200984 +0000
***************
*** 2624,2630 ****
  			   (< (point-max) c-state-old-cpp-end)))
  		  (point-max)
  		(min (point-max) c-state-old-cpp-beg)))
! 	(while (and c-state-cache (> (c-state-cache-top-lparen) upper-lim))
  	  (setq c-state-cache (cdr c-state-cache)))
  	;; If `upper-lim' is inside the last recorded brace pair, remove its
  	;; RBrace and indicate we'll need to search backwards for a previous
--- 2624,2630 ----
  			   (< (point-max) c-state-old-cpp-end)))
  		  (point-max)
  		(min (point-max) c-state-old-cpp-beg)))
! 	(while (and c-state-cache (>= (c-state-cache-top-lparen) upper-lim))
  	  (setq c-state-cache (cdr c-state-cache)))
  	;; If `upper-lim' is inside the last recorded brace pair, remove its
  	;; RBrace and indicate we'll need to search backwards for a previous


> -- 
> Ari Roponen

-- 
Alan Mackenzie (Nuremberg, Germany).

Message #11 received at 5747 <at> debbugs.gnu.org (full text, mbox):

From: Ari Roponen <ari.roponen <at> gmail.com>
To: Alan Mackenzie <acm <at> muc.de>
Cc: Michael Welsh Duggan <md5i <at> md5i.com>, 5747 <at> debbugs.gnu.org,
	Chong Yidong <cyd <at> stupidchicken.com>,
	Pogonyshev <pogonyshev <at> gmx.net>, Paul,
	Jan Djärv <jan.h.d <at> swipnet.se>
Subject: Re: bug#5747: 24.0.50; Unstable C-mode indentation
Date: Mon, 22 Mar 2010 14:03:39 +0200

Hi,

> Would you please (all) try the following patch, which I'm hopeful will
> fix all the recent instabilities in CC Modes indentation.
>

this patch fixes the problem I reported. Thank you.

>
> *** cc-engine.el~	2010-03-22 11:15:40.248931952 +0000
> --- cc-engine.el	2010-03-22 11:24:04.981200984 +0000
> ***************
> *** 2624,2630 ****
>   			   (< (point-max) c-state-old-cpp-end)))
>   		  (point-max)
>   		(min (point-max) c-state-old-cpp-beg)))
> ! 	(while (and c-state-cache (> (c-state-cache-top-lparen) upper-lim))
>   	  (setq c-state-cache (cdr c-state-cache)))
>   	;; If `upper-lim' is inside the last recorded brace pair, remove its
>   	;; RBrace and indicate we'll need to search backwards for a previous
> --- 2624,2630 ----
>   			   (< (point-max) c-state-old-cpp-end)))
>   		  (point-max)
>   		(min (point-max) c-state-old-cpp-beg)))
> ! 	(while (and c-state-cache (>= (c-state-cache-top-lparen) upper-lim))
>   	  (setq c-state-cache (cdr c-state-cache)))
>   	;; If `upper-lim' is inside the last recorded brace pair, remove its
>   	;; RBrace and indicate we'll need to search backwards for a previous
>

-- 
Ari Roponen

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.