GNU bug report logs - #56907
[PATCH] * eww.el (eww-browse): Raise error if there are no arguments

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#56907: closed ([PATCH] * eww.el (eww-browse): Raise error if
 there are no arguments)
Date: Thu, 04 Aug 2022 12:23:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 04 Aug 2022 12:22:00 +0000
with message-id <877d3o9p1z.fsf <at> posteo.net>
and subject line Re: bug#56907: [PATCH] * eww.el (eww-browse): Raise error if there are no arguments
has caused the debbugs.gnu.org bug report #56907,
regarding [PATCH] * eww.el (eww-browse): Raise error if there are no arguments
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
56907: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=56907
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Philip Kaludercic <philipk <at> posteo.net>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] * eww.el (eww-browse): Raise error if there are no arguments
Date: Wed, 03 Aug 2022 10:37:40 +0000

[Message part 3 (text/plain, inline)]

Tags: patch


If there are no command line arguments, then nil is passed to eww, and
eventually it is given to string-trim, that raises an apparently
unrelated error due to the missing string.

An alternative to this patch would be to unmark it as interactive, since
it appears to be meant for batch use.  I had initially confused it with
`eww-open-file'.


In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.34, cairo version 1.17.6)
 of 2022-08-01 built on rhea
Repository revision: 47f1cae83c269ea43d6b208e055ce536c017856f
Repository branch: feature/package+vc
System Description: Fedora Linux 36 (Workstation Edition)

Configured using:
 'configure --with-pgtk --with-native-compilation --with-imagemagick'

[0001-eww.el-eww-browse-Raise-error-if-there-are-no-argume.patch (text/patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Philip Kaludercic <philipk <at> posteo.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 56907-done <at> debbugs.gnu.org
Subject: Re: bug#56907: [PATCH] * eww.el (eww-browse): Raise error if there
 are no arguments
Date: Thu, 04 Aug 2022 12:22:00 +0000

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Philip Kaludercic <philipk <at> posteo.net> writes:
>
>> Subject: [PATCH] * eww.el (eww-browse): Raise error if there are no arguments
>
> Looks good to me; please go ahead and push.

Done.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.