GNU bug report logs - #56907
[PATCH] * eww.el (eww-browse): Raise error if there are no arguments

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 56907 in the body.
You can then email your comments to 56907 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] * eww.el (eww-browse): Raise error if there are no arguments
Date: Wed, 03 Aug 2022 10:37:40 +0000

[Message part 1 (text/plain, inline)]

Tags: patch


If there are no command line arguments, then nil is passed to eww, and
eventually it is given to string-trim, that raises an apparently
unrelated error due to the missing string.

An alternative to this patch would be to unmark it as interactive, since
it appears to be meant for batch use.  I had initially confused it with
`eww-open-file'.


In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.34, cairo version 1.17.6)
 of 2022-08-01 built on rhea
Repository revision: 47f1cae83c269ea43d6b208e055ce536c017856f
Repository branch: feature/package+vc
System Description: Fedora Linux 36 (Workstation Edition)

Configured using:
 'configure --with-pgtk --with-native-compilation --with-imagemagick'

[0001-eww.el-eww-browse-Raise-error-if-there-are-no-argume.patch (text/patch, attachment)]

Message #8 received at 56907 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: 56907 <at> debbugs.gnu.org
Subject: Re: bug#56907: [PATCH] * eww.el (eww-browse): Raise error if there
 are no arguments
Date: Thu, 04 Aug 2022 08:33:35 +0200

Philip Kaludercic <philipk <at> posteo.net> writes:

> Subject: [PATCH] * eww.el (eww-browse): Raise error if there are no arguments

Looks good to me; please go ahead and push.

Message #13 received at 56907-done <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 56907-done <at> debbugs.gnu.org
Subject: Re: bug#56907: [PATCH] * eww.el (eww-browse): Raise error if there
 are no arguments
Date: Thu, 04 Aug 2022 12:22:00 +0000

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Philip Kaludercic <philipk <at> posteo.net> writes:
>
>> Subject: [PATCH] * eww.el (eww-browse): Raise error if there are no arguments
>
> Looks good to me; please go ahead and push.

Done.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.