GNU bug report logs - #56800
Pointless "Warning: desktop file appears to be in use by PID ###."

Previous Next

Full log

Message #23 received at 56800 <at> debbugs.gnu.org (full text, mbox):

From: Paul Pogonyshev <pogonyshev <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 56800 <at> debbugs.gnu.org
Subject: Re: bug#56800: Pointless "Warning: desktop file appears to be in use
 by PID ###."
Date: Wed, 27 Jul 2022 21:22:46 +0200

[Message part 1 (text/plain, inline)]

I meant something like what is in the attached patch. The problem is that
_everything_ got moved to `...-query-functions', including that part that
has nothing to do with querying.

Paul



On Wed, 27 Jul 2022 at 20:58, Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: Paul Pogonyshev <pogonyshev <at> gmail.com>
> > Date: Wed, 27 Jul 2022 19:52:31 +0200
> > Cc: 56800 <at> debbugs.gnu.org
> >
> > Yeah, apparently `kill-emacs' is considered "low-level primitive":
> >
> >     Functions to call with no arguments to query about killing Emacs.
> >     If any of these functions returns nil, killing Emacs is canceled.
> >     ‘save-buffers-kill-emacs’ calls these functions, but ‘kill-emacs’,
> >     the low level primitive, does not.  See also ‘kill-emacs-hook’.
> >
> > Since I have rebound C-x C-c for my private use (why waste such a nice
> shortcut on something used once
> > in a few days?), I have been using `kill-emacs'. But apparently it's not
> what should be used... Emacs making
> > it easy to silently break things, nothing new.
> >
> > I suggest that `desktop-release-lock' call is still moved from something
> hooked on
> > `kill-emacs-query-functions' to `kill-emacs-hook'. That part is supposed
> to be done unconditionally.
>
> That change was made because the hook can ask questions, which doesn't
> work in a daemon session.  So we moved the hook.
>

[Message part 2 (text/html, inline)]

[0001-Followup-to-5bd04ea307-still-have-M-x-kill-emacs-rel.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.