GNU bug report logs - #56800
Pointless "Warning: desktop file appears to be in use by PID ###."

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 56800 in the body.
You can then email your comments to 56800 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Paul Pogonyshev <pogonyshev <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Pointless "Warning: desktop file appears to be in use by PID ###."
Date: Wed, 27 Jul 2022 18:25:24 +0200

[Message part 1 (text/plain, inline)]

GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 2.24.33,
cairo version 1.16.0) of 2022-07-26

Practically every time I start up Emacs, I get this pointless warning and a
question if I really want to use the desktop file anyway. If there were
actually another Emacs running, this warning would be fine, even useful.
However, in 95% of cases here it happens because computer was shut down,
Emacs crashed etc. In fact, I have just now verified that even if I cleanly
`M-x kill-emacs RET' my Emacs and then start a new one, the new still
thinks that the old, killed Emacs might still be using the desktop file
somehow (i.e. PID is that of the previous Emacs process).

The code in `desktop.el' should really check if the process with that PID
still exists before claiming that it might be using the desktop file
somehow.

Paul

[Message part 2 (text/html, inline)]

Message #8 received at 56800 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Paul Pogonyshev <pogonyshev <at> gmail.com>
Cc: 56800 <at> debbugs.gnu.org
Subject: Re: bug#56800: Pointless "Warning: desktop file appears to be in use
 by PID ###."
Date: Wed, 27 Jul 2022 19:49:46 +0300

> From: Paul Pogonyshev <pogonyshev <at> gmail.com>
> Date: Wed, 27 Jul 2022 18:25:24 +0200
> 
> The code in `desktop.el' should really check if the process with that PID still exists before claiming that it
> might be using the desktop file somehow.

AFAIU, you should be able to have that if you customize
desktop-load-locked-desktop to give it the value 'check-pid'.  Did you
try that?

Message #11 received at 56800 <at> debbugs.gnu.org (full text, mbox):

From: Paul Pogonyshev <pogonyshev <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 56800 <at> debbugs.gnu.org
Subject: Re: bug#56800: Pointless "Warning: desktop file appears to be in use
 by PID ###."
Date: Wed, 27 Jul 2022 18:58:36 +0200

[Message part 1 (text/plain, inline)]

No, but I have tried now. I guess I understand the default behavior better
now (even if I don't find it generally useful enough to be the default; how
many users really have remotely mounted paths in `desktop-dirname'?).

But why does even cleanly exiting Emacs leave desktop file "apparently
used"?

Paul

On Wed, 27 Jul 2022 at 18:50, Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: Paul Pogonyshev <pogonyshev <at> gmail.com>
> > Date: Wed, 27 Jul 2022 18:25:24 +0200
> >
> > The code in `desktop.el' should really check if the process with that
> PID still exists before claiming that it
> > might be using the desktop file somehow.
>
> AFAIU, you should be able to have that if you customize
> desktop-load-locked-desktop to give it the value 'check-pid'.  Did you
> try that?
>

[Message part 2 (text/html, inline)]

Message #14 received at 56800 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Paul Pogonyshev <pogonyshev <at> gmail.com>
Cc: 56800 <at> debbugs.gnu.org
Subject: Re: bug#56800: Pointless "Warning: desktop file appears to be in use
 by PID ###."
Date: Wed, 27 Jul 2022 20:32:56 +0300

> From: Paul Pogonyshev <pogonyshev <at> gmail.com>
> Date: Wed, 27 Jul 2022 18:58:36 +0200
> Cc: 56800 <at> debbugs.gnu.org
> 
> But why does even cleanly exiting Emacs leave desktop file "apparently used"?

It shouldn't, and it doesn't here.  Something I hope you will look
into and tell what you found.

Message #17 received at 56800 <at> debbugs.gnu.org (full text, mbox):

From: Paul Pogonyshev <pogonyshev <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 56800 <at> debbugs.gnu.org
Subject: Re: bug#56800: Pointless "Warning: desktop file appears to be in use
 by PID ###."
Date: Wed, 27 Jul 2022 19:52:31 +0200

[Message part 1 (text/plain, inline)]

Yeah, apparently `kill-emacs' is considered "low-level primitive":

    Functions to call with no arguments to query about killing Emacs.
    If any of these functions returns nil, killing Emacs is canceled.
    ‘save-buffers-kill-emacs’ calls these functions, but ‘kill-emacs’,
    the low level primitive, does not.  See also ‘kill-emacs-hook’.

Since I have rebound C-x C-c for my private use (why waste such a nice
shortcut on something used once in a few days?), I have been using
`kill-emacs'. But apparently it's not what should be used... Emacs making
it easy to silently break things, nothing new.

I suggest that `desktop-release-lock' call is still moved from something
hooked on `kill-emacs-query-functions' to `kill-emacs-hook'. That part is
supposed to be done unconditionally.

Paul

On Wed, 27 Jul 2022 at 19:32, Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: Paul Pogonyshev <pogonyshev <at> gmail.com>
> > Date: Wed, 27 Jul 2022 18:58:36 +0200
> > Cc: 56800 <at> debbugs.gnu.org
> >
> > But why does even cleanly exiting Emacs leave desktop file "apparently
> used"?
>
> It shouldn't, and it doesn't here.  Something I hope you will look
> into and tell what you found.
>

[Message part 2 (text/html, inline)]

Message #20 received at 56800 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Paul Pogonyshev <pogonyshev <at> gmail.com>
Cc: 56800 <at> debbugs.gnu.org
Subject: Re: bug#56800: Pointless "Warning: desktop file appears to be in use
 by PID ###."
Date: Wed, 27 Jul 2022 21:58:54 +0300

> From: Paul Pogonyshev <pogonyshev <at> gmail.com>
> Date: Wed, 27 Jul 2022 19:52:31 +0200
> Cc: 56800 <at> debbugs.gnu.org
> 
> Yeah, apparently `kill-emacs' is considered "low-level primitive":
> 
>     Functions to call with no arguments to query about killing Emacs.
>     If any of these functions returns nil, killing Emacs is canceled.
>     ‘save-buffers-kill-emacs’ calls these functions, but ‘kill-emacs’,
>     the low level primitive, does not.  See also ‘kill-emacs-hook’.
> 
> Since I have rebound C-x C-c for my private use (why waste such a nice shortcut on something used once
> in a few days?), I have been using `kill-emacs'. But apparently it's not what should be used... Emacs making
> it easy to silently break things, nothing new.
> 
> I suggest that `desktop-release-lock' call is still moved from something hooked on
> `kill-emacs-query-functions' to `kill-emacs-hook'. That part is supposed to be done unconditionally.

That change was made because the hook can ask questions, which doesn't
work in a daemon session.  So we moved the hook.

Message #23 received at 56800 <at> debbugs.gnu.org (full text, mbox):

From: Paul Pogonyshev <pogonyshev <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 56800 <at> debbugs.gnu.org
Subject: Re: bug#56800: Pointless "Warning: desktop file appears to be in use
 by PID ###."
Date: Wed, 27 Jul 2022 21:22:46 +0200

[Message part 1 (text/plain, inline)]

I meant something like what is in the attached patch. The problem is that
_everything_ got moved to `...-query-functions', including that part that
has nothing to do with querying.

Paul



On Wed, 27 Jul 2022 at 20:58, Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: Paul Pogonyshev <pogonyshev <at> gmail.com>
> > Date: Wed, 27 Jul 2022 19:52:31 +0200
> > Cc: 56800 <at> debbugs.gnu.org
> >
> > Yeah, apparently `kill-emacs' is considered "low-level primitive":
> >
> >     Functions to call with no arguments to query about killing Emacs.
> >     If any of these functions returns nil, killing Emacs is canceled.
> >     ‘save-buffers-kill-emacs’ calls these functions, but ‘kill-emacs’,
> >     the low level primitive, does not.  See also ‘kill-emacs-hook’.
> >
> > Since I have rebound C-x C-c for my private use (why waste such a nice
> shortcut on something used once
> > in a few days?), I have been using `kill-emacs'. But apparently it's not
> what should be used... Emacs making
> > it easy to silently break things, nothing new.
> >
> > I suggest that `desktop-release-lock' call is still moved from something
> hooked on
> > `kill-emacs-query-functions' to `kill-emacs-hook'. That part is supposed
> to be done unconditionally.
>
> That change was made because the hook can ask questions, which doesn't
> work in a daemon session.  So we moved the hook.
>

[Message part 2 (text/html, inline)]

[0001-Followup-to-5bd04ea307-still-have-M-x-kill-emacs-rel.patch (text/x-patch, attachment)]

Message #28 received at 56800-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Paul Pogonyshev <pogonyshev <at> gmail.com>
Cc: 56800-done <at> debbugs.gnu.org
Subject: Re: bug#56800: Pointless "Warning: desktop file appears to be in use
 by PID ###."
Date: Thu, 28 Jul 2022 09:17:17 +0300

> From: Paul Pogonyshev <pogonyshev <at> gmail.com>
> Date: Wed, 27 Jul 2022 21:22:46 +0200
> Cc: 56800 <at> debbugs.gnu.org
> 
> I meant something like what is in the attached patch. The problem is that _everything_ got moved to
> `...-query-functions', including that part that has nothing to do with querying.

Thanks, installed on the emacs-28 release branch.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.