GNU bug report logs - #56742
29.0.50; Python indendation problem after comment

Previous Next

Full log

View this message in rfc822 format

From: Stephen Berman <stephen.berman <at> gmx.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: kobarity <kobarity <at> gmail.com>, 56742 <at> debbugs.gnu.org
Subject: bug#56742: 29.0.50; Python indendation problem after comment
Date: Wed, 27 Jul 2022 20:01:01 +0200

On Wed, 27 Jul 2022 11:39:04 +0200 Lars Ingebrigtsen <larsi <at> gnus.org> wrote:

> kobarity <kobarity <at> gmail.com> writes:
>
>> I'm not so familiar with this part of python.el, but it looks good to me.
>
> Thanks; I've now applied Stephen's patch to Emacs 29.

Thanks!

>> How about modifying the ERT to address this issue?
>>
>> diff --git a/test/lisp/progmodes/python-tests.el
>> b/test/lisp/progmodes/python-tests.el
>> index 3b10bde23b..3828d4d5aa 100644
>> --- a/test/lisp/progmodes/python-tests.el
>> +++ b/test/lisp/progmodes/python-tests.el
>> @@ -1108,6 +1108,7 @@ python-indent-dedenters-2
>>      except Exception:
>>          if hide_details:
>>              logger.exception('Unhandled exception')
>> +        # comment
>>              else
>>      finally:
>>          data.free()
>
> And I added a new test that does this (so that we have a test both with
> and without the #comment).

And thanks for that too.

Steve Berman

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.