GNU bug report logs - #56552
[PATCH] Make gnus display webp images inline

Previous Next

Full log

Message #8 received at 56552 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Visuwesh <visuweshm <at> gmail.com>
Cc: 56552 <at> debbugs.gnu.org
Subject: Re: bug#56552: [PATCH] Make gnus display webp images inline
Date: Thu, 14 Jul 2022 06:42:44 -0700

Visuwesh <visuweshm <at> gmail.com> writes:

> diff --git a/lisp/gnus/mm-decode.el b/lisp/gnus/mm-decode.el
> index 7256e5a2f7..79217d3400 100644
> --- a/lisp/gnus/mm-decode.el
> +++ b/lisp/gnus/mm-decode.el
> @@ -193,7 +193,11 @@ mm-inline-media-tests
>    `(("image/p?jpeg"
>       mm-inline-image
>       ,(lambda (handle)
> -       (mm-valid-and-fit-image-p 'jpeg handle)))
> +        (mm-valid-and-fit-image-p 'jpeg handle)))
> +    ("image/webp"
> +     mm-inline-image
> +     ,(lambda (handle)
> +       (mm-valid-and-fit-image-p 'webp handle)))
>      ("image/png"
>       mm-inline-image
>       ,(lambda (handle)

Maybe this comment belongs in a separate wishlist item, but why isn't
this all using the `image-file-name-regexp' function?

I'm looking at `org-display-inline-images', and it seems to me that
org-mode didn't need any additional changes at all to get support for
inline webp images once Emacs had it?  So would it be better if Gnus did
things more like org-mode?

> diff --git a/lisp/net/mailcap.el b/lisp/net/mailcap.el
> index 8ba7f1bec3..ee72eba35d 100644
> --- a/lisp/net/mailcap.el
> +++ b/lisp/net/mailcap.el
> @@ -974,6 +974,7 @@ mailcap-mime-extensions
>      (".ai"    . "application/postscript")
>      (".jpe"   . "image/jpeg")
>      (".jpeg"  . "image/jpeg")
> +    (".webp"  . "image/webp")
>      (".org"   . "text/x-org"))
>    "An alist of file extensions and corresponding MIME content-types.
>  This exists for you to customize the information in Lisp.  It is

This part LGTM.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.