GNU bug report logs - #56551
29.0.50; Errors in xterm.c when building --without-all

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 56551 in the body.
You can then email your comments to 56551 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; Errors in xterm.c when building --without-all
Date: Thu, 14 Jul 2022 04:47:29 -0700

When building master --without-all, I get:

xterm.c: In function ‘x_scroll_bar_expose’:
xterm.c:14973:20: warning: variable ‘height’ set but not used
[-Wunused-but-set-variable]
14973 |   int x, y, width, height;
      |                    ^~~~~~
xterm.c:14973:13: warning: variable ‘width’ set but not used
[-Wunused-but-set-variable]
14973 |   int x, y, width, height;
      |             ^~~~~
xterm.c:14973:10: warning: variable ‘y’ set but not used
[-Wunused-but-set-variable]
14973 |   int x, y, width, height;
      |          ^
xterm.c:14973:7: warning: variable ‘x’ set but not used
[-Wunused-but-set-variable]
14973 |   int x, y, width, height;
      |       ^
xterm.c: In function ‘handle_one_xevent’:
xterm.c:18674:15: warning: implicit declaration of function
‘FRAME_X_DOUBLE_BUFFERED_P’ [-Wimplicit-function-declaration]
18674 |           if (FRAME_X_DOUBLE_BUFFERED_P (f))
      |               ^~~~~~~~~~~~~~~~~~~~~~~~~
xterm.c:18674:15: warning: nested extern declaration of
‘FRAME_X_DOUBLE_BUFFERED_P’ [-Wnested-externs]
xterm.c:18675:13: warning: implicit declaration of function
‘x_drop_xrender_surfaces’; did you mean ‘font_drop_xrender_surfaces’?
[-Wimplicit-function-declaration]
18675 |             x_drop_xrender_surfaces (f);
      |             ^~~~~~~~~~~~~~~~~~~~~~~
      |             font_drop_xrender_surfaces
xterm.c:18675:13: warning: nested extern declaration of
‘x_drop_xrender_surfaces’ [-Wnested-externs]
xterm.c: In function ‘mark_xterm’:
xterm.c:27956:8: error: ‘dpyinfo’ undeclared (first use in this function)
27956 |   for (dpyinfo = x_display_list; dpyinfo; dpyinfo = dpyinfo->next)
      |        ^~~~~~~
xterm.c:27956:8: note: each undeclared identifier is reported only
once for each function it appears in
make[1]: *** [Makefile:421: xterm.o] Error 1
make[1]: Target 'all' not remade because of errors.

In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.24, cairo version 1.16.0)
 of 2022-07-08 built on joffe
Repository revision: 9abf841429257a3e1008bedc4d857ea7a25ab9a6
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: Debian GNU/Linux 11 (bullseye)

Message #8 received at 56551 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 56551 <at> debbugs.gnu.org
Subject: Re: bug#56551: 29.0.50; Errors in xterm.c when building --without-all
Date: Thu, 14 Jul 2022 16:38:49 +0300

> From: Stefan Kangas <stefan <at> marxist.se>
> Date: Thu, 14 Jul 2022 04:47:29 -0700
> 
> When building master --without-all, I get:
> 
> xterm.c: In function ‘x_scroll_bar_expose’:
> xterm.c:14973:20: warning: variable ‘height’ set but not used
> [-Wunused-but-set-variable]
> 14973 |   int x, y, width, height;
>       |                    ^~~~~~
> xterm.c:14973:13: warning: variable ‘width’ set but not used
> [-Wunused-but-set-variable]
> 14973 |   int x, y, width, height;
>       |             ^~~~~
> xterm.c:14973:10: warning: variable ‘y’ set but not used
> [-Wunused-but-set-variable]
> 14973 |   int x, y, width, height;
>       |          ^
> xterm.c:14973:7: warning: variable ‘x’ set but not used
> [-Wunused-but-set-variable]
> 14973 |   int x, y, width, height;
>       |       ^
> xterm.c: In function ‘handle_one_xevent’:
> xterm.c:18674:15: warning: implicit declaration of function
> ‘FRAME_X_DOUBLE_BUFFERED_P’ [-Wimplicit-function-declaration]
> 18674 |           if (FRAME_X_DOUBLE_BUFFERED_P (f))
>       |               ^~~~~~~~~~~~~~~~~~~~~~~~~
> xterm.c:18674:15: warning: nested extern declaration of
> ‘FRAME_X_DOUBLE_BUFFERED_P’ [-Wnested-externs]
> xterm.c:18675:13: warning: implicit declaration of function
> ‘x_drop_xrender_surfaces’; did you mean ‘font_drop_xrender_surfaces’?
> [-Wimplicit-function-declaration]
> 18675 |             x_drop_xrender_surfaces (f);
>       |             ^~~~~~~~~~~~~~~~~~~~~~~
>       |             font_drop_xrender_surfaces
> xterm.c:18675:13: warning: nested extern declaration of
> ‘x_drop_xrender_surfaces’ [-Wnested-externs]
> xterm.c: In function ‘mark_xterm’:
> xterm.c:27956:8: error: ‘dpyinfo’ undeclared (first use in this function)
> 27956 |   for (dpyinfo = x_display_list; dpyinfo; dpyinfo = dpyinfo->next)
>       |        ^~~~~~~
> xterm.c:27956:8: note: each undeclared identifier is reported only
> once for each function it appears in
> make[1]: *** [Makefile:421: xterm.o] Error 1
> make[1]: Target 'all' not remade because of errors.

Did I succeed to fix this now?

Message #11 received at 56551 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 56551 <at> debbugs.gnu.org
Subject: Re: bug#56551: 29.0.50; Errors in xterm.c when building --without-all
Date: Thu, 14 Jul 2022 07:50:33 -0700

Eli Zaretskii <eliz <at> gnu.org> writes:

> Did I succeed to fix this now?

Thanks, it builds now.  These warnings remain, in case they're worth
fixing:

xterm.c: In function ‘x_scroll_bar_expose’:
xterm.c:14970:20: warning: variable ‘height’ set but not used
[-Wunused-but-set-variable]
14970 |   int x, y, width, height;
      |                    ^~~~~~
xterm.c:14970:13: warning: variable ‘width’ set but not used
[-Wunused-but-set-variable]
14970 |   int x, y, width, height;
      |             ^~~~~
xterm.c:14970:10: warning: variable ‘y’ set but not used
[-Wunused-but-set-variable]
14970 |   int x, y, width, height;
      |          ^
xterm.c:14970:7: warning: variable ‘x’ set but not used
[-Wunused-but-set-variable]
14970 |   int x, y, width, height;
      |       ^
xterm.c: In function ‘mark_xterm’:
xterm.c:27942:7: warning: unused variable ‘i’ [-Wunused-variable]
27942 |   int i;
      |       ^

In file included from gtkutil.c:29:
gtkutil.c: In function ‘xg_free_frame_widgets’:
gtkutil.c:1890:17: warning: implicit declaration of function
‘FRAME_X_DOUBLE_BUFFERED_P’ [-Wimplicit-function-declaration]
 1890 |       eassert (!FRAME_X_DOUBLE_BUFFERED_P (f));
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~
lisp.h:174:43: note: in definition of macro ‘eassert’
  174 | # define eassert(cond) ((void) (false && (cond))) /* Check
COND compiles.  */
      |                                           ^~~~
gtkutil.c:1890:17: warning: nested extern declaration of
‘FRAME_X_DOUBLE_BUFFERED_P’ [-Wnested-externs]
 1890 |       eassert (!FRAME_X_DOUBLE_BUFFERED_P (f));
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~
lisp.h:174:43: note: in definition of macro ‘eassert’
  174 | # define eassert(cond) ((void) (false && (cond))) /* Check
COND compiles.  */
      |                                           ^~~~

Message #14 received at 56551 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 56551 <at> debbugs.gnu.org
Subject: Re: bug#56551: 29.0.50; Errors in xterm.c when building --without-all
Date: Thu, 14 Jul 2022 11:13:58 -0400

./configure --with-x-toolkit=athena \
  --without-toolkit-scroll-bars --without-xaw3d

is now broken due to issues with x, y, width, height being undeclared.

Message #17 received at 56551 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 56551 <at> debbugs.gnu.org, stefan <at> marxist.se
Subject: Re: bug#56551: 29.0.50; Errors in xterm.c when building --without-all
Date: Thu, 14 Jul 2022 19:01:07 +0300

> From: Glenn Morris <rgm <at> gnu.org>
> Cc: Eli Zaretskii <eliz <at> gnu.org>,  56551 <at> debbugs.gnu.org
> Date: Thu, 14 Jul 2022 11:13:58 -0400
> 
> 
> ./configure --with-x-toolkit=athena \
>   --without-toolkit-scroll-bars --without-xaw3d
> 
> is now broken due to issues with x, y, width, height being undeclared.

If it's still broken, I'd appreciate the error messages.

Message #20 received at 56551 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Glenn Morris <rgm <at> gnu.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 56551 <at> debbugs.gnu.org,
 Stefan Kangas <stefan <at> marxist.se>
Subject: Re: bug#56551: 29.0.50; Errors in xterm.c when building --without-all
Date: Fri, 15 Jul 2022 10:19:07 +0800

Glenn Morris <rgm <at> gnu.org> writes:

> ./configure --with-x-toolkit=athena \
>   --without-toolkit-scroll-bars --without-xaw3d
>
> is now broken due to issues with x, y, width, height being undeclared.

It works for me, could you please show the error?

Message #25 received at 56551-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Po Lu <luangruo <at> yahoo.com>
Cc: Glenn Morris <rgm <at> gnu.org>, Eli Zaretskii <eliz <at> gnu.org>,
 56551-done <at> debbugs.gnu.org
Subject: Re: bug#56551: 29.0.50; Errors in xterm.c when building --without-all
Date: Thu, 4 Aug 2022 15:18:35 +0000

Po Lu <luangruo <at> yahoo.com> writes:

> Glenn Morris <rgm <at> gnu.org> writes:
>
>> ./configure --with-x-toolkit=athena \
>>   --without-toolkit-scroll-bars --without-xaw3d
>>
>> is now broken due to issues with x, y, width, height being undeclared.
>
> It works for me, could you please show the error?

No further comments within 3 weeks, and the above works for me on latest
master.  I'm therefore closing this bug report.

Please reopen if this is still an issue.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.