GNU bug report logs - #56552
[PATCH] Make gnus display webp images inline

Previous Next

Full log

Message #17 received at 56552 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 56552 <at> debbugs.gnu.org, Visuwesh <visuweshm <at> gmail.com>
Subject: Re: bug#56552: [PATCH] Make gnus display webp images inline
Date: Thu, 14 Jul 2022 19:44:52 +0200

Stefan Kangas <stefan <at> marxist.se> writes:

>>    `(("image/p?jpeg"
>>       mm-inline-image
>>       ,(lambda (handle)
>> -       (mm-valid-and-fit-image-p 'jpeg handle)))
>> +        (mm-valid-and-fit-image-p 'jpeg handle)))
>> +    ("image/webp"
>> +     mm-inline-image
>> +     ,(lambda (handle)
>> +       (mm-valid-and-fit-image-p 'webp handle)))
>>      ("image/png"
>>       mm-inline-image
>>       ,(lambda (handle)
>
> Maybe this comment belongs in a separate wishlist item, but why isn't
> this all using the `image-file-name-regexp' function?

I think this code is this way for historical reasons -- different image
types were handled differently at one time (I think), but they now all
call `mm-valid-and-fit-image-p'.  So, yes, it should all be rewritten.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.