GNU bug report logs - #56413
[PATCH 1/1] scm_i_utf8_string_hash: compute u8 chars not bytes

Previous Next

Package: guile;

Reported by: Rob Browning <rlb <at> defaultvalue.org>

Date: Wed, 6 Jul 2022 01:25:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Rob Browning <rlb <at> defaultvalue.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 56413 <at> debbugs.gnu.org
Subject: bug#56413: [PATCH 1/1] scm_i_utf8_string_hash: compute u8 chars not bytes
Date: Sun, 06 Nov 2022 10:44:50 -0600
Ludovic Courtès <ludo <at> gnu.org> writes:

> For the final patch please add a ChangeLog-style entry.

Will do.

> Is this a documented example of Jenkins?  Or did you use a reference
> implementation?

Jenkins?

> Yes, it may be nicer to have it in ‘test-suite/tests/hash.test’.
>
> AFAICS this will only change the hash of UTF-8 symbols and won’t have
> any effect on the output of ‘string-hash’, right?  If not that would be
> an incompatibility.

I think that's right, but I'll have to refresh my memory regarding the
changes.  (Haven't gotten back to the utf-8 work for a bit so it's not
top of mind, though I hope to soon.)

Thanks
-- 
Rob Browning
rlb @defaultvalue.org and @debian.org
GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A
GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4




This bug report was last modified 2 years and 64 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.