GNU bug report logs - #56248
[PATCH 0/7] Remove use of older check-0.14 from most packages

Previous Next

Full log

Message #56 received at 56248 <at> debbugs.gnu.org (full text, mbox):

From: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
To: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>
Cc: 56248 <at> debbugs.gnu.org
Subject: Re: [PATCH 1/7] gnu: recutils: Use regular check version
Date: Sat, 02 Jul 2022 01:09:57 -0300

Hello Liliana,

Thank you for your prompt review!

Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at> writes:

> Am Montag, dem 27.06.2022 um 02:02 -0300 schrieb Thiago Jung Bauermann:
>> recutils builds fine with the regular version of check, so use it.
> Mostly duplicate information.  Also you're missing the period at the
> end of the message title.  I suggest shortening it to “gnu: recutils:
> Use regular check.”
>
>> * gnu/packages/databases.scm (recutils)[native-inputs]: Use regular
>> version of check.
> Should be “Replace check-0.14 with check.” or similar.
>
>
> Likewise for all the other patches, otherwise LGTM.

These are good points. I adopted your suggestions in the v2.

-- 
Thanks
Thiago

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.