GNU bug report logs - #56248
[PATCH 0/7] Remove use of older check-0.14 from most packages

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 56248 in the body.
You can then email your comments to 56248 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
To: guix-patches <at> gnu.org
Cc: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
Subject: [PATCH 0/7] Remove use of older check-0.14 from most packages
Date: Mon, 27 Jun 2022 01:43:39 -0300

Hello,

Move packages that are currently using check-0.14 to regular check. Except
for libwapcaplet, which still needs the older version, all others build
fine with the newer one. I noticed this issue because check-0.14 doesn't
build on powerpc64le, and that prevented me from building recutils.

These patches can go on the master branch because according to “guix
refresh -l”, they have few dependents:

- recutils: A single dependent package: emacs-helm-system-packages <at> 1.10.2
- libsigrokdecode: Building the following 2 packages would ensure
  2 dependent packages are rebuilt: pulseview <at> 0.4.2 sigrok-cli <at> 0.7.2
- burp :: No dependents other than itself: burp <at> 2.3.38
- edi :: No dependents other than itself: edi <at> 0.8.0
- libsbml :: Building the following 1 package would ensure 2 dependent
  packages are rebuilt: r-biggr <at> 1.32.0
- iodine :: No dependents other than itself: iodine <at> 0.7.0
- gdm :: Building the following 4 packages would ensure 6 dependent
  packages are rebuilt: gnome-shell-extension-gsconnect <at> 48
  arc-theme <at> 20210412 numix-gtk-theme <at> 2.6.7 gnome <at> 41.0

To test this series, I built all the packages mentioned above on
x86_64-linux. I also built the following ones on powerpc64le-linux:

recutils, emacs-helm-system-packages, libsigrokdecode, sigrok-cli, burp,
libsbml, iodine.

The others don't currently build on powerpc64le-linux for other reasons.

Thiago Jung Bauermann (7):
  gnu: recutils: Use regular check version
  gnu: libsigrokdecode: Use regular check version
  gnu: burp: Use regular check version
  gnu: edi: Use regular check version
  gnu: libsbml: Use regular check version
  gnu: iodine: Use regular check version
  gnu: gdm: Use regular check version

 gnu/packages/backup.scm         | 2 +-
 gnu/packages/bioinformatics.scm | 2 +-
 gnu/packages/databases.scm      | 2 +-
 gnu/packages/electronics.scm    | 2 +-
 gnu/packages/enlightenment.scm  | 2 +-
 gnu/packages/gnome.scm          | 2 +-
 gnu/packages/networking.scm     | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)


base-commit: d86ad3d8dff0f6f3d63e52a9309fac9fe279c77a

Message #8 received at 56248 <at> debbugs.gnu.org (full text, mbox):

From: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
To: 56248 <at> debbugs.gnu.org
Cc: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
Subject: [PATCH 1/7] gnu: recutils: Use regular check version
Date: Mon, 27 Jun 2022 02:02:11 -0300

recutils builds fine with the regular version of check, so use it.

* gnu/packages/databases.scm (recutils)[native-inputs]: Use regular version of
check.
---
 gnu/packages/databases.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
index 72200fce92d0..0d4405ef90e5 100644
--- a/gnu/packages/databases.scm
+++ b/gnu/packages/databases.scm
@@ -1577,7 +1577,7 @@ (define-public recutils
      ;; XXX Without labels, the default 'configure phase picks the wrong "bash".
      `(("bc" ,bc)
        ("bash:include" ,bash "include")
-       ("check" ,check-0.14)
+       ("check" ,check)
        ("pkg-config" ,pkg-config)))
     (inputs
      ;; TODO: Add more optional inputs.

Message #11 received at 56248 <at> debbugs.gnu.org (full text, mbox):

From: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
To: 56248 <at> debbugs.gnu.org
Cc: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
Subject: [PATCH 2/7] gnu: libsigrokdecode: Use regular check version
Date: Mon, 27 Jun 2022 02:02:12 -0300

libsigrokdecode builds fine with the regular version of check, so use it.

* gnu/packages/electronics.scm (libsigrokdecode)[native-inputs]: Use regular
version of check.
---
 gnu/packages/electronics.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/electronics.scm b/gnu/packages/electronics.scm
index 6e303f3fdca7..70d960aaab47 100644
--- a/gnu/packages/electronics.scm
+++ b/gnu/packages/electronics.scm
@@ -112,7 +112,7 @@ (define-public libsigrokdecode
                                               "/share/doc/libsigrokdecode"))
              #t)))))
     (native-inputs
-     (list check-0.14 doxygen graphviz pkg-config automake autoconf))
+     (list check doxygen graphviz pkg-config automake autoconf))
     ;; libsigrokdecode.pc lists "python" in Requires.private, and "glib" in Requires.
     (propagated-inputs
      (list glib python))

Message #14 received at 56248 <at> debbugs.gnu.org (full text, mbox):

From: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
To: 56248 <at> debbugs.gnu.org
Cc: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
Subject: [PATCH 3/7] gnu: burp: Use regular check version
Date: Mon, 27 Jun 2022 02:02:13 -0300

burp builds fine with the regular version of check, so use it.

* gnu/packages/backup.scm (burp)[native-inputs]: Use regular version of check.
---
 gnu/packages/backup.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/backup.scm b/gnu/packages/backup.scm
index 5646d909e54a..42c3301958e1 100644
--- a/gnu/packages/backup.scm
+++ b/gnu/packages/backup.scm
@@ -1198,7 +1198,7 @@ (define-public burp
            uthash
            zlib))
     (native-inputs
-     (list autoconf automake check-0.14 pkg-config))
+     (list autoconf automake check pkg-config))
     (home-page "https://burp.grke.org")
     (synopsis "Differential backup and restore")
     (description "Burp is a network backup and restore program.  It attempts

Message #17 received at 56248 <at> debbugs.gnu.org (full text, mbox):

From: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
To: 56248 <at> debbugs.gnu.org
Cc: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
Subject: [PATCH 4/7] gnu: edi: Use regular check version
Date: Mon, 27 Jun 2022 02:02:14 -0300

edi builds fine with the regular version of check, so use it.

* gnu/packages/enlightenment.scm (edi)[native-inputs]: Use regular version of
check.
---
 gnu/packages/enlightenment.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/enlightenment.scm b/gnu/packages/enlightenment.scm
index 12d5a56d6a0b..eae3f76301d4 100644
--- a/gnu/packages/enlightenment.scm
+++ b/gnu/packages/enlightenment.scm
@@ -465,7 +465,7 @@ (define-public edi
            (lambda _ (setenv "HOME" "/tmp") #t)))
        #:tests? #f)) ; tests require running dbus service
     (native-inputs
-     `(("check" ,check-0.14)
+     `(("check" ,check)
        ("gettext" ,gettext-minimal)
        ("pkg-config" ,pkg-config)))
     (inputs

Message #20 received at 56248 <at> debbugs.gnu.org (full text, mbox):

From: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
To: 56248 <at> debbugs.gnu.org
Cc: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
Subject: [PATCH 5/7] gnu: libsbml: Use regular check version
Date: Mon, 27 Jun 2022 02:02:15 -0300

libsbml builds fine with the regular version of check, so use it.

* gnu/packages/bioinformatics.scm (libsbml)[native-inputs]: Use regular version
of check.
---
 gnu/packages/bioinformatics.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
index 75973b0dd8fe..bc2d653ba6f2 100644
--- a/gnu/packages/bioinformatics.scm
+++ b/gnu/packages/bioinformatics.scm
@@ -14459,7 +14459,7 @@ (define-public libsbml
     (propagated-inputs
      (list libxml2))
     (native-inputs
-     (list check-0.14 swig))
+     (list check swig))
     (home-page "http://sbml.org/Software/libSBML")
     (synopsis "Process SBML files and data streams")
     (description "LibSBML is a library to help you read, write, manipulate,

Message #23 received at 56248 <at> debbugs.gnu.org (full text, mbox):

From: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
To: 56248 <at> debbugs.gnu.org
Cc: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
Subject: [PATCH 6/7] gnu: iodine: Use regular check version
Date: Mon, 27 Jun 2022 02:02:16 -0300

iodine builds fine with the regular version of check, so use it.

* gnu/packages/networking.scm (iodine)[native-inputs]: Use regular version of
check.
---
 gnu/packages/networking.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index b4c50bc783ed..ef8c09a777e3 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -1548,7 +1548,7 @@ (define-public iodine
                           (string-append "prefix=" (assoc-ref %outputs "out")))
        #:test-target "test"))
     (inputs (list net-tools zlib))
-    (native-inputs (list check-0.14 pkg-config))
+    (native-inputs (list check pkg-config))
     (home-page "https://code.kryo.se/iodine/")
     (synopsis "Tunnel IPv4 data through a DNS server")
     (description "Iodine tunnels IPv4 data through a DNS server.  This

Message #26 received at 56248 <at> debbugs.gnu.org (full text, mbox):

From: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
To: 56248 <at> debbugs.gnu.org
Cc: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
Subject: [PATCH 7/7] gnu: gdm: Use regular check version
Date: Mon, 27 Jun 2022 02:02:17 -0300

gdm builds fine with the regular version of check, so use it.

* gnu/packages/gnome.scm (gdm)[native-inputs]: Use regular version of check.
---
 gnu/packages/gnome.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 0cde3caebde8..135d522699a3 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -8372,7 +8372,7 @@ (define-public gdm
        ("xmllint" ,libxml2)))
     (inputs
      (list accountsservice
-           check-0.14 ;for testing
+           check ;for testing
            elogind
            eudev
            gnome-session

Message #29 received at 56248 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>
To: Thiago Jung Bauermann <bauermann <at> kolabnow.com>, 56248 <at> debbugs.gnu.org
Subject: Re: [PATCH 1/7] gnu: recutils: Use regular check version
Date: Mon, 27 Jun 2022 08:04:06 +0200

Am Montag, dem 27.06.2022 um 02:02 -0300 schrieb Thiago Jung Bauermann:
> recutils builds fine with the regular version of check, so use it.
Mostly duplicate information.  Also you're missing the period at the
end of the message title.  I suggest shortening it to “gnu: recutils:
Use regular check.”

> * gnu/packages/databases.scm (recutils)[native-inputs]: Use regular
> version of check.
Should be “Replace check-0.14 with check.” or similar.


Likewise for all the other patches, otherwise LGTM.

Message #32 received at 56248 <at> debbugs.gnu.org (full text, mbox):

From: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
To: 56248 <at> debbugs.gnu.org
Cc: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
Subject: [PATCH v2 0/7] Remove use of older check-0.14 from most packages
Date: Sat,  2 Jul 2022 01:07:50 -0300

Hello,

This version addresses Liliana's comments about the message title, body
and changelog, by adopting her suggestions.

Original cover letter:

Move packages that are currently using check-0.14 to regular check. Except
for libwapcaplet, which still needs the older version, all others build
fine with the newer one. I noticed this issue because check-0.14 doesn't
build on powerpc64le, and that prevented me from building recutils.

These patches can go on the master branch because according to “guix
refresh -l”, they have few dependents:

- recutils: A single dependent package: emacs-helm-system-packages <at> 1.10.2
- libsigrokdecode: Building the following 2 packages would ensure
  2 dependent packages are rebuilt: pulseview <at> 0.4.2 sigrok-cli <at> 0.7.2
- burp :: No dependents other than itself: burp <at> 2.3.38
- edi :: No dependents other than itself: edi <at> 0.8.0
- libsbml :: Building the following 1 package would ensure 2 dependent
  packages are rebuilt: r-biggr <at> 1.32.0
- iodine :: No dependents other than itself: iodine <at> 0.7.0
- gdm :: Building the following 4 packages would ensure 6 dependent
  packages are rebuilt: gnome-shell-extension-gsconnect <at> 48
  arc-theme <at> 20210412 numix-gtk-theme <at> 2.6.7 gnome <at> 41.0

To test this series, I built all the packages mentioned above on
x86_64-linux. I also built the following ones on powerpc64le-linux:

recutils, emacs-helm-system-packages, libsigrokdecode, sigrok-cli, burp,
libsbml, iodine.

The others don't currently build on powerpc64le-linux for other reasons.

Thiago Jung Bauermann (7):
  gnu: recutils: Use regular check.
  gnu: libsigrokdecode: Use regular check.
  gnu: burp: Use regular check.
  gnu: edi: Use regular check.
  gnu: libsbml: Use regular check.
  gnu: iodine: Use regular check.
  gnu: gdm: Use regular check.

 gnu/packages/backup.scm         | 2 +-
 gnu/packages/bioinformatics.scm | 2 +-
 gnu/packages/databases.scm      | 2 +-
 gnu/packages/electronics.scm    | 2 +-
 gnu/packages/enlightenment.scm  | 2 +-
 gnu/packages/gnome.scm          | 2 +-
 gnu/packages/networking.scm     | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)


base-commit: d86ad3d8dff0f6f3d63e52a9309fac9fe279c77a

Message #35 received at 56248 <at> debbugs.gnu.org (full text, mbox):

From: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
To: 56248 <at> debbugs.gnu.org
Cc: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
Subject: [PATCH v2 2/7] gnu: libsigrokdecode: Use regular check.
Date: Sat,  2 Jul 2022 01:07:52 -0300

* gnu/packages/electronics.scm (libsigrokdecode)[native-inputs]: Replace
check-0.14 with check.
---
 gnu/packages/electronics.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/electronics.scm b/gnu/packages/electronics.scm
index 6e303f3fdca7..70d960aaab47 100644
--- a/gnu/packages/electronics.scm
+++ b/gnu/packages/electronics.scm
@@ -112,7 +112,7 @@ (define-public libsigrokdecode
                                               "/share/doc/libsigrokdecode"))
              #t)))))
     (native-inputs
-     (list check-0.14 doxygen graphviz pkg-config automake autoconf))
+     (list check doxygen graphviz pkg-config automake autoconf))
     ;; libsigrokdecode.pc lists "python" in Requires.private, and "glib" in Requires.
     (propagated-inputs
      (list glib python))

Message #38 received at 56248 <at> debbugs.gnu.org (full text, mbox):

From: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
To: 56248 <at> debbugs.gnu.org
Cc: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
Subject: [PATCH v2 1/7] gnu: recutils: Use regular check.
Date: Sat,  2 Jul 2022 01:07:51 -0300

* gnu/packages/databases.scm (recutils)[native-inputs]: Replace check-0.14
with check.
---
 gnu/packages/databases.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
index 72200fce92d0..0d4405ef90e5 100644
--- a/gnu/packages/databases.scm
+++ b/gnu/packages/databases.scm
@@ -1577,7 +1577,7 @@ (define-public recutils
      ;; XXX Without labels, the default 'configure phase picks the wrong "bash".
      `(("bc" ,bc)
        ("bash:include" ,bash "include")
-       ("check" ,check-0.14)
+       ("check" ,check)
        ("pkg-config" ,pkg-config)))
     (inputs
      ;; TODO: Add more optional inputs.

Message #41 received at 56248 <at> debbugs.gnu.org (full text, mbox):

From: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
To: 56248 <at> debbugs.gnu.org
Cc: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
Subject: [PATCH v2 3/7] gnu: burp: Use regular check.
Date: Sat,  2 Jul 2022 01:07:53 -0300

* gnu/packages/backup.scm (burp)[native-inputs]: Replace check-0.14 with
check.
---
 gnu/packages/backup.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/backup.scm b/gnu/packages/backup.scm
index 5646d909e54a..42c3301958e1 100644
--- a/gnu/packages/backup.scm
+++ b/gnu/packages/backup.scm
@@ -1198,7 +1198,7 @@ (define-public burp
            uthash
            zlib))
     (native-inputs
-     (list autoconf automake check-0.14 pkg-config))
+     (list autoconf automake check pkg-config))
     (home-page "https://burp.grke.org")
     (synopsis "Differential backup and restore")
     (description "Burp is a network backup and restore program.  It attempts

Message #44 received at 56248 <at> debbugs.gnu.org (full text, mbox):

From: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
To: 56248 <at> debbugs.gnu.org
Cc: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
Subject: [PATCH v2 4/7] gnu: edi: Use regular check.
Date: Sat,  2 Jul 2022 01:07:54 -0300

* gnu/packages/enlightenment.scm (edi)[native-inputs]: Replace check-0.14 with
check.
---
 gnu/packages/enlightenment.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/enlightenment.scm b/gnu/packages/enlightenment.scm
index 12d5a56d6a0b..eae3f76301d4 100644
--- a/gnu/packages/enlightenment.scm
+++ b/gnu/packages/enlightenment.scm
@@ -465,7 +465,7 @@ (define-public edi
            (lambda _ (setenv "HOME" "/tmp") #t)))
        #:tests? #f)) ; tests require running dbus service
     (native-inputs
-     `(("check" ,check-0.14)
+     `(("check" ,check)
        ("gettext" ,gettext-minimal)
        ("pkg-config" ,pkg-config)))
     (inputs

Message #47 received at 56248 <at> debbugs.gnu.org (full text, mbox):

From: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
To: 56248 <at> debbugs.gnu.org
Cc: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
Subject: [PATCH v2 5/7] gnu: libsbml: Use regular check.
Date: Sat,  2 Jul 2022 01:07:55 -0300

* gnu/packages/bioinformatics.scm (libsbml)[native-inputs]: Replace check-0.14
with check.
---
 gnu/packages/bioinformatics.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
index 75973b0dd8fe..bc2d653ba6f2 100644
--- a/gnu/packages/bioinformatics.scm
+++ b/gnu/packages/bioinformatics.scm
@@ -14459,7 +14459,7 @@ (define-public libsbml
     (propagated-inputs
      (list libxml2))
     (native-inputs
-     (list check-0.14 swig))
+     (list check swig))
     (home-page "http://sbml.org/Software/libSBML")
     (synopsis "Process SBML files and data streams")
     (description "LibSBML is a library to help you read, write, manipulate,

Message #50 received at 56248 <at> debbugs.gnu.org (full text, mbox):

From: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
To: 56248 <at> debbugs.gnu.org
Cc: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
Subject: [PATCH v2 6/7] gnu: iodine: Use regular check.
Date: Sat,  2 Jul 2022 01:07:56 -0300

* gnu/packages/networking.scm (iodine)[native-inputs]: Replace check-0.14 with
check.
---
 gnu/packages/networking.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index b4c50bc783ed..ef8c09a777e3 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -1548,7 +1548,7 @@ (define-public iodine
                           (string-append "prefix=" (assoc-ref %outputs "out")))
        #:test-target "test"))
     (inputs (list net-tools zlib))
-    (native-inputs (list check-0.14 pkg-config))
+    (native-inputs (list check pkg-config))
     (home-page "https://code.kryo.se/iodine/")
     (synopsis "Tunnel IPv4 data through a DNS server")
     (description "Iodine tunnels IPv4 data through a DNS server.  This

Message #53 received at 56248 <at> debbugs.gnu.org (full text, mbox):

From: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
To: 56248 <at> debbugs.gnu.org
Cc: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
Subject: [PATCH v2 7/7] gnu: gdm: Use regular check.
Date: Sat,  2 Jul 2022 01:07:57 -0300

* gnu/packages/gnome.scm (gdm)[native-inputs]: Replace check-0.14 with check.
---
 gnu/packages/gnome.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 0cde3caebde8..135d522699a3 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -8372,7 +8372,7 @@ (define-public gdm
        ("xmllint" ,libxml2)))
     (inputs
      (list accountsservice
-           check-0.14 ;for testing
+           check ;for testing
            elogind
            eudev
            gnome-session

Message #56 received at 56248 <at> debbugs.gnu.org (full text, mbox):

From: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
To: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>
Cc: 56248 <at> debbugs.gnu.org
Subject: Re: [PATCH 1/7] gnu: recutils: Use regular check version
Date: Sat, 02 Jul 2022 01:09:57 -0300

Hello Liliana,

Thank you for your prompt review!

Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at> writes:

> Am Montag, dem 27.06.2022 um 02:02 -0300 schrieb Thiago Jung Bauermann:
>> recutils builds fine with the regular version of check, so use it.
> Mostly duplicate information.  Also you're missing the period at the
> end of the message title.  I suggest shortening it to “gnu: recutils:
> Use regular check.”
>
>> * gnu/packages/databases.scm (recutils)[native-inputs]: Use regular
>> version of check.
> Should be “Replace check-0.14 with check.” or similar.
>
>
> Likewise for all the other patches, otherwise LGTM.

These are good points. I adopted your suggestions in the v2.

-- 
Thanks
Thiago

Message #61 received at 56248-done <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Thiago Jung Bauermann <bauermann <at> kolabnow.com>, 56248-done <at> debbugs.gnu.org
Subject: Re: [PATCH v2 0/7] Remove use of older check-0.14 from most packages
Date: Sat, 02 Jul 2022 12:00:28 +0200

Am Samstag, dem 02.07.2022 um 01:07 -0300 schrieb Thiago Jung
Bauermann:
> Hello,
> 
> This version addresses Liliana's comments about the message title,
> body and changelog, by adopting her suggestions.
Pushed to master.

Thanks

Message #64 received at 56248-done <at> debbugs.gnu.org (full text, mbox):

From: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 56248-done <at> debbugs.gnu.org
Subject: Re: [PATCH v2 0/7] Remove use of older check-0.14 from most packages
Date: Sat, 02 Jul 2022 21:23:34 -0300

Hello,

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> Am Samstag, dem 02.07.2022 um 01:07 -0300 schrieb Thiago Jung
> Bauermann:
>> Hello,
>> 
>> This version addresses Liliana's comments about the message title,
>> body and changelog, by adopting her suggestions.
> Pushed to master.

Thank you!

-- 
Thanks
Thiago

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.