GNU bug report logs - #55977
29.0.50; [PATCH] repeat-mode: Don't echo unset keys in help message

Previous Next

Full log

View this message in rfc822 format

From: Juri Linkov <juri <at> linkov.net>
To: Visuwesh <visuweshm <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 55977 <at> debbugs.gnu.org
Subject: bug#55977: 29.0.50; [PATCH] repeat-mode: Don't echo unset keys in help message
Date: Wed, 15 Jun 2022 10:25:03 +0300

close 55977 29.0.50
thanks

>>>> repeat-mode echoes unset keys in the help message since it doesn't check
>>>> for non-nil value of command bound to key; will attach patch once I get
>>>> the bug number.
>>>
>>> Thanks, but can you please show a recipe from "emacs -Q", to
>>> understand better what problem are you trying to fix?
>>
>> Sure.
>>
>>     1. M-x repeat-mode RET.
>>     2. C-h n.
>>     3. M-: (define-key outline-navigation-repeat-map (kbd "C-n") nil).
>>     4. C-c @ C-n.  Notice how the help message still says C-n despite
>>        being unbound, and when you type C-n the repeat map exits
>>        contrary to what the message says.
>
> Oh, looks like if I give `define-key' a non-nil REMOVE argument, then
> C-n is no longer displayed in the help message.

Indeed, the REMOVE removes a key, but nil is also a valid way to undefine a key,
so now your patch is pushed to master, thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.