GNU bug report logs - #55977
29.0.50; [PATCH] repeat-mode: Don't echo unset keys in help message

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55977 in the body.
You can then email your comments to 55977 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; [PATCH] repeat-mode: Don't echo unset keys in help message
Date: Tue, 14 Jun 2022 22:57:48 +0530

Tags: patch

repeat-mode echoes unset keys in the help message since it doesn't check
for non-nil value of command bound to key; will attach patch once I get
the bug number.

In GNU Emacs 29.0.50 (build 16, x86_64-pc-linux-gnu, X toolkit, Xaw scroll bars)
 of 2022-06-14 built on astatine
Repository revision: 9fb80aee176f6d5dc8fd33b63880b11a99a19657
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101003
System Description: Debian GNU/Linux 11 (bullseye)

Configured using:
 'configure --with-modules --with-sound=alsa --with-x-toolkit=lucid
 --with-json --without-xaw3d --without-gconf --without-libsystemd
 --with-x --without-cairo'

Configured features:
ACL DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON
LIBOTF LIBSELINUX LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG RSVG
SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11 XDBE XFT
XIM XINPUT2 XPM LUCID ZLIB

Message #8 received at 55977 <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: 55977 <at> debbugs.gnu.org
Subject: 29.0.50; [PATCH] repeat-mode: Don't echo unset keys in help message
Date: Tue, 14 Jun 2022 23:00:59 +0530

[Message part 1 (text/plain, inline)]

Patch attached.

[0001-repeat-mode-Don-t-echo-unset-keys-in-help-message.patch (text/x-diff, attachment)]

Message #11 received at 55977 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Visuwesh <visuweshm <at> gmail.com>
Cc: 55977 <at> debbugs.gnu.org
Subject: Re: bug#55977: 29.0.50;
 [PATCH] repeat-mode: Don't echo unset keys in help message
Date: Tue, 14 Jun 2022 20:40:29 +0300

> From: Visuwesh <visuweshm <at> gmail.com>
> Date: Tue, 14 Jun 2022 22:57:48 +0530
> 
> repeat-mode echoes unset keys in the help message since it doesn't check
> for non-nil value of command bound to key; will attach patch once I get
> the bug number.

Thanks, but can you please show a recipe from "emacs -Q", to
understand better what problem are you trying to fix?

Message #14 received at 55977 <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 55977 <at> debbugs.gnu.org
Subject: Re: bug#55977: 29.0.50; [PATCH] repeat-mode: Don't echo unset keys
 in help message
Date: Tue, 14 Jun 2022 23:32:17 +0530

[செவ்வாய் ஜூன் 14, 2022 20:40] Eli Zaretskii wrote:

>> From: Visuwesh <visuweshm <at> gmail.com>
>> Date: Tue, 14 Jun 2022 22:57:48 +0530
>> 
>> repeat-mode echoes unset keys in the help message since it doesn't check
>> for non-nil value of command bound to key; will attach patch once I get
>> the bug number.
>
> Thanks, but can you please show a recipe from "emacs -Q", to
> understand better what problem are you trying to fix?

Sure.

    1. M-x repeat-mode RET.
    2. C-h n.
    3. M-: (define-key outline-navigation-repeat-map (kbd "C-n") nil).
    4. C-c @ C-n.  Notice how the help message still says C-n despite
       being unbound, and when you type C-n the repeat map exits
       contrary to what the message says.

Message #17 received at 55977 <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 55977 <at> debbugs.gnu.org
Subject: Re: bug#55977: 29.0.50; [PATCH] repeat-mode: Don't echo unset keys
 in help message
Date: Tue, 14 Jun 2022 23:39:34 +0530

[செவ்வாய் ஜூன் 14, 2022 23:32] Visuwesh wrote:

> [செவ்வாய் ஜூன் 14, 2022 20:40] Eli Zaretskii wrote:
>
>>> From: Visuwesh <visuweshm <at> gmail.com>
>>> Date: Tue, 14 Jun 2022 22:57:48 +0530
>>> 
>>> repeat-mode echoes unset keys in the help message since it doesn't check
>>> for non-nil value of command bound to key; will attach patch once I get
>>> the bug number.
>>
>> Thanks, but can you please show a recipe from "emacs -Q", to
>> understand better what problem are you trying to fix?
>
> Sure.
>
>     1. M-x repeat-mode RET.
>     2. C-h n.
>     3. M-: (define-key outline-navigation-repeat-map (kbd "C-n") nil).
>     4. C-c @ C-n.  Notice how the help message still says C-n despite
>        being unbound, and when you type C-n the repeat map exits
>        contrary to what the message says.

Oh, looks like if I give `define-key' a non-nil REMOVE argument, then
C-n is no longer displayed in the help message.

Message #20 received at 55977 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Visuwesh <visuweshm <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 55977 <at> debbugs.gnu.org
Subject: Re: bug#55977: 29.0.50; [PATCH] repeat-mode: Don't echo unset keys
 in help message
Date: Wed, 15 Jun 2022 10:25:03 +0300

close 55977 29.0.50
thanks

>>>> repeat-mode echoes unset keys in the help message since it doesn't check
>>>> for non-nil value of command bound to key; will attach patch once I get
>>>> the bug number.
>>>
>>> Thanks, but can you please show a recipe from "emacs -Q", to
>>> understand better what problem are you trying to fix?
>>
>> Sure.
>>
>>     1. M-x repeat-mode RET.
>>     2. C-h n.
>>     3. M-: (define-key outline-navigation-repeat-map (kbd "C-n") nil).
>>     4. C-c @ C-n.  Notice how the help message still says C-n despite
>>        being unbound, and when you type C-n the repeat map exits
>>        contrary to what the message says.
>
> Oh, looks like if I give `define-key' a non-nil REMOVE argument, then
> C-n is no longer displayed in the help message.

Indeed, the REMOVE removes a key, but nil is also a valid way to undefine a key,
so now your patch is pushed to master, thanks.

Message #25 received at 55977 <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: Juri Linkov <juri <at> linkov.net>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 55977 <at> debbugs.gnu.org
Subject: Re: bug#55977: 29.0.50; [PATCH] repeat-mode: Don't echo unset keys
 in help message
Date: Wed, 15 Jun 2022 13:06:45 +0530

[புதன் ஜூன் 15, 2022 10:25] Juri Linkov wrote:

> close 55977 29.0.50
> thanks
>
>>>>> repeat-mode echoes unset keys in the help message since it doesn't check
>>>>> for non-nil value of command bound to key; will attach patch once I get
>>>>> the bug number.
>>>>
>>>> Thanks, but can you please show a recipe from "emacs -Q", to
>>>> understand better what problem are you trying to fix?
>>>
>>> Sure.
>>>
>>>     1. M-x repeat-mode RET.
>>>     2. C-h n.
>>>     3. M-: (define-key outline-navigation-repeat-map (kbd "C-n") nil).
>>>     4. C-c @ C-n.  Notice how the help message still says C-n despite
>>>        being unbound, and when you type C-n the repeat map exits
>>>        contrary to what the message says.
>>
>> Oh, looks like if I give `define-key' a non-nil REMOVE argument, then
>> C-n is no longer displayed in the help message.
>
> Indeed, the REMOVE removes a key, but nil is also a valid way to undefine a key,
> so now your patch is pushed to master, thanks.

Great, thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.