GNU bug report logs - #55977
29.0.50; [PATCH] repeat-mode: Don't echo unset keys in help message

Previous Next

Package: emacs;

Reported by: Visuwesh <visuweshm <at> gmail.com>

Date: Tue, 14 Jun 2022 17:29:02 UTC

Severity: normal

Tags: patch

Fixed in version 29.0.50

Done: Juri Linkov <juri <at> linkov.net>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Visuwesh <visuweshm <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 55977 <at> debbugs.gnu.org
Subject: bug#55977: 29.0.50; [PATCH] repeat-mode: Don't echo unset keys in help message
Date: Tue, 14 Jun 2022 23:32:17 +0530
[செவ்வாய் ஜூன் 14, 2022 20:40] Eli Zaretskii wrote:

>> From: Visuwesh <visuweshm <at> gmail.com>
>> Date: Tue, 14 Jun 2022 22:57:48 +0530
>> 
>> repeat-mode echoes unset keys in the help message since it doesn't check
>> for non-nil value of command bound to key; will attach patch once I get
>> the bug number.
>
> Thanks, but can you please show a recipe from "emacs -Q", to
> understand better what problem are you trying to fix?

Sure.

    1. M-x repeat-mode RET.
    2. C-h n.
    3. M-: (define-key outline-navigation-repeat-map (kbd "C-n") nil).
    4. C-c @ C-n.  Notice how the help message still says C-n despite
       being unbound, and when you type C-n the repeat map exits
       contrary to what the message says.




This bug report was last modified 2 years and 340 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.