GNU bug report logs - #55976
[PATCH] gnu: valgrind/interactive: Update to 3.19.0.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Greg Hogan <code <at> greghogan.com>
Subject: bug#55976: closed (Re: [bug#55976] [PATCH] gnu: valgrind/interactive:
 Update to 3.19.0.)
Date: Mon, 07 Nov 2022 18:37:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#55976: [PATCH] gnu: valgrind/interactive: Update to 3.19.0.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 55976 <at> debbugs.gnu.org.

-- 
55976: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=55976
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Greg Hogan <code <at> greghogan.com>
To: 55976-done <at> debbugs.gnu.org
Subject: Re: [bug#55976] [PATCH] gnu: valgrind/interactive: Update to 3.19.0.
Date: Mon, 7 Nov 2022 13:36:38 -0500

24 October 2022: valgrind-3.20.0 is available.

On Wed, Jun 15, 2022 at 9:55 AM Greg Hogan <code <at> greghogan.com> wrote:
>
> On Tue, Jun 14, 2022 at 5:29 PM Tobias Geerinckx-Rice <me <at> tobias.gr> wrote:
> >
> > Hi Greg,
> >
> > Greg Hogan 写道：
> > > * gnu/packages/valgrind.scm (valgrind/interactive): Update to
> > > 3.19.0.
> > > [home-page]: Update permanent redirect.
> > > * gnu/packages/valgrind.scm (valgrind-3.18): Delete.
> > > ---
> > > This patch bumps the version of the non-hidden valgrind while
> > > removing
> > > the pinned-version package.
> >
> > Unless I'm mistaken these 2 tasks are independent, and should
> > hence be split across 2 patches.
>
> I will split the commit and send a v2 patchset upon confirmation of
> the valgrind-3.18 removal..
>
> > >                             Looking through the commit history,
> > >                             I do see
> > > a reason for having both a valgrind/interactive and
> > > valgrind-3.18.
> >
> > I thought this was a typo for ‘don't’ at first, but I really can't
> > tell.
>
> You are correct, this should have said "don't see a reason".
>
> > I don't see a reason to keep both now, but then I don't see one
> > when 50f7402c was committed either.  Do you remember, Ludo'?
> >
> > Kind regards,
> >
> > T G-R
>
> Thanks for the review!
>
> Greg

[Message part 3 (message/rfc822, inline)]

From: Greg Hogan <code <at> greghogan.com>
To: guix-patches <at> gnu.org
Cc: Greg Hogan <code <at> greghogan.com>
Subject: [PATCH] gnu: valgrind/interactive: Update to 3.19.0.
Date: Tue, 14 Jun 2022 15:38:13 +0000

* gnu/packages/valgrind.scm (valgrind/interactive): Update to 3.19.0.
[home-page]: Update permanent redirect.
* gnu/packages/valgrind.scm (valgrind-3.18): Delete.
---
This patch bumps the version of the non-hidden valgrind while removing
the pinned-version package. Looking through the commit history, I do see
a reason for having both a valgrind/interactive and valgrind-3.18.

$ ./pre-inst-env guix refresh -l valgrind
No dependents other than itself: valgrind <at> 3.19.0

 gnu/packages/valgrind.scm | 20 +++-----------------
 1 file changed, 3 insertions(+), 17 deletions(-)

diff --git a/gnu/packages/valgrind.scm b/gnu/packages/valgrind.scm
index 63524d59e9..8e9a4c39f4 100644
--- a/gnu/packages/valgrind.scm
+++ b/gnu/packages/valgrind.scm
@@ -79,7 +79,7 @@ (define-public valgrind
                #t))))))
     (native-inputs
      (list perl))
-    (home-page "https://www.valgrind.org/")
+    (home-page "https://valgrind.org/")
     (synopsis "Debugging and profiling tool suite")
     (description
      "Valgrind is an instrumentation framework for building dynamic analysis
@@ -96,7 +96,7 @@ (define-public valgrind
 (define-public valgrind/interactive
   (package/inherit
    valgrind
-   (version "3.17.0")
+   (version "3.19.0")
    (source (origin
              (method url-fetch)
              (uri (list (string-append "https://sourceware.org/pub/valgrind"
@@ -105,7 +105,7 @@ (define-public valgrind/interactive
                                        "/valgrind-" version ".tar.bz2")))
              (sha256
               (base32
-               "18l5jbk301j3462gipqn9bkfx44mdmwn0pwr73r40gl1irkfqfmd"))
+               "00lgfgb38xbrilkw6xvqk284dcnnnhbcq03kpvvkyj0sdx438pnx"))
              (patches (search-patches
                        "valgrind-enable-arm.patch"
                        "valgrind-fix-default-debuginfo-path.patch"))))
@@ -148,17 +148,3 @@ (define-public valgrind/interactive
                       (string-length "/usr/lib/debug")
                       1))))))))))
    (properties '())))
-
-(define-public valgrind-3.18
-  (package
-    (inherit valgrind/interactive)
-    (version "3.18.1")
-    (source (origin
-              (inherit (package-source valgrind/interactive))
-              (uri (list (string-append "https://sourceware.org/pub/valgrind"
-                                        "/valgrind-" version ".tar.bz2")
-                         (string-append "ftp://sourceware.org/pub/valgrind"
-                                        "/valgrind-" version ".tar.bz2")))
-              (sha256
-               (base32
-                "1xgph509i6adv9w2glviw3xrmlz0dssg8992hbvxsbkp7ahrm180"))))))
-- 
2.36.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.