GNU bug report logs - #55944
[PATCH] Fix dns-mode-font-lock-keywords

Previous Next

Package: emacs;

Reported by: Lassi Kortela <lassi <at> lassi.io>

Date: Mon, 13 Jun 2022 14:21:02 UTC

Severity: normal

Tags: patch

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55944 in the body.
You can then email your comments to 55944 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#55944; Package emacs. (Mon, 13 Jun 2022 14:21:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Lassi Kortela <lassi <at> lassi.io>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Mon, 13 Jun 2022 14:21:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lassi Kortela <lassi <at> lassi.io>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fix dns-mode-font-lock-keywords
Date: Mon, 13 Jun 2022 13:58:08 +0300

[Message part 1 (text/plain, inline)]
Attached is a simple fix to the syntax highlighting of dns-mode.

For example, IN and SOA are reserved words. Instead of highlighting only 
the full words IN and SOA, dns-mode would highlight any word that has IN 
or SOA as a substring. This patch fixes the use of regexp-opt such that 
reserved words are only highlighted when they are full words.
[dns-mode-font-lock-keywords.patch (text/plain, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#55944; Package emacs. (Mon, 13 Jun 2022 14:34:01 GMT) Full text and rfc822 format available.

Message #8 received at 55944 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Lassi Kortela <lassi <at> lassi.io>
Cc: 55944 <at> debbugs.gnu.org
Subject: Re: bug#55944: [PATCH] Fix dns-mode-font-lock-keywords
Date: Mon, 13 Jun 2022 16:33:16 +0200

Lassi Kortela <lassi <at> lassi.io> writes:

> Attached is a simple fix to the syntax highlighting of dns-mode.
>
> For example, IN and SOA are reserved words. Instead of highlighting
> only the full words IN and SOA, dns-mode would highlight any word that
> has IN or SOA as a substring. This patch fixes the use of regexp-opt
> such that reserved words are only highlighted when they are full
> words.

Thanks; pushed to Emacs 29.

This change was small enough to apply without assigning copyright to the
FSF, but for future patches you want to submit, it might make sense to
get the paperwork started now, so that subsequent patches can be applied
speedily. Would you be willing to sign such paperwork?
bug marked as fixed in version 29.1, send any further explanations to 55944 <at> debbugs.gnu.org and Lassi Kortela <lassi <at> lassi.io> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Mon, 13 Jun 2022 14:34:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 12 Jul 2022 11:24:07 GMT) Full text and rfc822 format available.
This bug report was last modified 2 years and 343 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.