GNU bug report logs - #55715
[PATCH] gnu: ocaml-ctypes: do not override install headers

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#55715: closed ([PATCH] gnu: ocaml-ctypes: do not override
 install headers)
Date: Thu, 02 Jun 2022 05:55:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 2 Jun 2022 07:54:40 +0200
with message-id <20220602075440.09a9127c <at> sybil.lepiller.eu>
and subject line Re: [bug#55715] [PATCH] gnu: ocaml-ctypes: do not override install headers
has caused the debbugs.gnu.org bug report #55715,
regarding [PATCH] gnu: ocaml-ctypes: do not override install headers
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
55715: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=55715
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: David Arroyo <david <at> aqwari.net>
To: guix-patches <at> gnu.org
Cc: David Arroyo <david <at> aqwari.net>
Subject: [PATCH] gnu: ocaml-ctypes: do not override install headers
Date: Sun, 29 May 2022 16:42:34 -0400

Overriding INSTALL_HEADERS in the build prevents the "ocaml_integers.h"
header from being copied from the ocaml-integers package to ocaml-ctypes.
The header's absence breaks all dune-based projects which build cstubs
using the new (ctypes ...) stanza.

* gnu/packages/ocaml.scm:
  [arguments]: remove INSTALL_HEADERS override.
---
 gnu/packages/ocaml.scm | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
index e6d6bc7a89..c7da5a2106 100644
--- a/gnu/packages/ocaml.scm
+++ b/gnu/packages/ocaml.scm
@@ -4333,9 +4333,7 @@ (define-public ocaml-ctypes
                "0ilzq9qzvwv9rc08cc9wchsx636zp870i7qvqmbigaa2qb812m0z"))))
    (build-system ocaml-build-system)
    (arguments
-    `(#:make-flags
-      (list (string-append "INSTALL_HEADERS = $(wildcard $($(PROJECT).dir)/*.h)"))
-      #:phases
+    `(#:phases
       (modify-phases %standard-phases
         (add-after 'unpack 'make-writable
           (lambda _
-- 
2.36.1

[Message part 3 (message/rfc822, inline)]

From: Julien Lepiller <julien <at> lepiller.eu>
To: David Arroyo <david <at> aqwari.net>
Cc: 55715-done <at> debbugs.gnu.org
Subject: Re: [bug#55715] [PATCH] gnu: ocaml-ctypes: do not override install
 headers
Date: Thu, 2 Jun 2022 07:54:40 +0200

Le Sun, 29 May 2022 16:42:34 -0400,
David Arroyo <david <at> aqwari.net> a écrit :

> * gnu/packages/ocaml.scm:
>   [arguments]: remove INSTALL_HEADERS override.

Pushed to master as 21800bf8b98871c99c0a91d97690be1df07a2659 with a
small change to the commit message. Thanks for the patch and enjoy!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.