GNU bug report logs - #55715
[PATCH] gnu: ocaml-ctypes: do not override install headers

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55715 in the body.
You can then email your comments to 55715 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: David Arroyo <david <at> aqwari.net>
To: guix-patches <at> gnu.org
Cc: David Arroyo <david <at> aqwari.net>
Subject: [PATCH] gnu: ocaml-ctypes: do not override install headers
Date: Sun, 29 May 2022 16:42:34 -0400

Overriding INSTALL_HEADERS in the build prevents the "ocaml_integers.h"
header from being copied from the ocaml-integers package to ocaml-ctypes.
The header's absence breaks all dune-based projects which build cstubs
using the new (ctypes ...) stanza.

* gnu/packages/ocaml.scm:
  [arguments]: remove INSTALL_HEADERS override.
---
 gnu/packages/ocaml.scm | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
index e6d6bc7a89..c7da5a2106 100644
--- a/gnu/packages/ocaml.scm
+++ b/gnu/packages/ocaml.scm
@@ -4333,9 +4333,7 @@ (define-public ocaml-ctypes
                "0ilzq9qzvwv9rc08cc9wchsx636zp870i7qvqmbigaa2qb812m0z"))))
    (build-system ocaml-build-system)
    (arguments
-    `(#:make-flags
-      (list (string-append "INSTALL_HEADERS = $(wildcard $($(PROJECT).dir)/*.h)"))
-      #:phases
+    `(#:phases
       (modify-phases %standard-phases
         (add-after 'unpack 'make-writable
           (lambda _
-- 
2.36.1

Message #10 received at 55715-done <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: David Arroyo <david <at> aqwari.net>
Cc: 55715-done <at> debbugs.gnu.org
Subject: Re: [bug#55715] [PATCH] gnu: ocaml-ctypes: do not override install
 headers
Date: Thu, 2 Jun 2022 07:54:40 +0200

Le Sun, 29 May 2022 16:42:34 -0400,
David Arroyo <david <at> aqwari.net> a écrit :

> * gnu/packages/ocaml.scm:
>   [arguments]: remove INSTALL_HEADERS override.

Pushed to master as 21800bf8b98871c99c0a91d97690be1df07a2659 with a
small change to the commit message. Thanks for the patch and enjoy!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.