GNU bug report logs - #55608
[PATCH] gnu: Add pbuilder.

Previous Next

Full log

Message #8 received at 55608 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Efraim Flashner <efraim <at> flashner.co.il>, 55608 <at> debbugs.gnu.org
Cc: Vagrant Cascadian <vagrant <at> debian.org>
Subject: Re: [bug#55608] [PATCH] gnu: Add pbuilder.
Date: Tue, 24 May 2022 12:09:36 +0200

[Message part 1 (text/plain, inline)]

Efraim Flashner schreef op di 24-05-2022 om 10:59 [+0300]:
> +           (add-after 'install-more 'wrap-programs
> +             (lambda* (#:key native-inputs inputs outputs #:allow-other-keys)
> +               (for-each
> +                 (lambda (file)
> +                   (wrap-script file
> +                    `("PATH" ":" prefix
> +                      (,(dirname (search-input-file (or native-inputs inputs) "/bin/cut"))
> +                       ,(dirname (search-input-file (or native-inputs inputs) "/bin/dpkg"))
> +                       ,(dirname (search-input-file (or native-inputs inputs) "/bin/grep"))
> +                       ,(dirname (search-input-file (or native-inputs inputs) "/bin/perl"))
> +                       ,(dirname (search-input-file (or native-inputs inputs) "/bin/sed"))
> +                       ,(dirname (search-input-file (or native-inputs inputs) "/bin/which"))
> +                       ,(dirname (search-input-file (or native-inputs inputs) "/sbin/debootstrap"))))))

Shouldn't these be inputs instead of native-inputs, because they will
end up being run when pbuilder is run?  Likewise for'patch-source'.
Also, can be simplified to

[...] "PATH" ":" prefix ,(map (compose dirname (cut search-input-file inputs <>)) '("/bin/cut" "/bin/dpkg" ...)) [...]

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.