GNU bug report logs - #55188
[PATCH] gnu: Add python-vitables.

Previous Next

Full log

Message #8 received at 55188 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Peter Polidoro <peter <at> polidoro.io>
Cc: 55188 <at> debbugs.gnu.org
Subject: Re: bug#55188: [PATCH] gnu: Add python-vitables.
Date: Mon, 09 May 2022 11:29:38 +0200

Hello Peter,

> +    (arguments
> +     `(#:tests? #f))

You should add a comment stating why the tests are disabled. Because
there are no tests or because they are failing, and if so why?

> +    (description "ViTables is a GUI for browsing and editing files in both
> +PyTables and HDF5 formats. ViTables capabilities include easy navigation
> +through the data hierarchy, displaying of real data and its associated
> +metadata, a simple, yet powerful, browsing of multidimensional data and much
> +more. As a viewer, one of the greatest strengths of ViTables is its ability to
> +display very large datasets.")
> +    (license license:gpl3)))

The description could be more neutral: you could remove the "yet
powerful" and "much more" parts. The last sentence could also be
reworded: "As a viewer, ViTables is able to display very large datasets."
feels more factual.

Could you send an updated patch :) ?

Thanks,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.