GNU bug report logs - #55188
[PATCH] gnu: Add python-vitables.

Previous Next

To reply to this bug, email your comments to 55188 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Peter Polidoro <peter <at> polidoro.io>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add python-vitables.
Date: Fri, 29 Apr 2022 13:13:38 -0400

[0001-gnu-Add-python-vitables.patch (text/x-diff, attachment)]

From 53b4108bf283b4e54da069078f18716dadf91b9b Mon Sep 17 00:00:00 2001
From: Peter Polidoro <peter <at> polidoro.io>
Date: Fri, 29 Apr 2022 13:12:46 -0400
Subject: [PATCH] gnu: Add python-vitables.

* gnu/packages/python-xyz.scm (python-vitables): New variable.
---
 gnu/packages/python-xyz.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index f8e599a453..20ecb372db 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -29587,3 +29587,32 @@ (define-public python-mike
 versions of MkDocs-powered docs to a Git branch.  It is suitable for deploying
 to Github via gh-pages.")
     (license license:bsd-3)))
+
+(define-public python-vitables
+  (package
+    (name "python-vitables")
+    (version "3.0.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "ViTables" version))
+       (sha256
+        (base32 "1vk80a8jbg0phxgf31rnm7gq34mllv7hb5h0bypz4kv7n3150iln"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     (list python-numexpr
+           python-numpy
+           python-pyqt
+           python-qtpy
+           python-tables))
+    (arguments
+     `(#:tests? #f))
+    (home-page "https://vitables.org")
+    (synopsis "GUI for browsing PyTables and HDF5 files")
+    (description "ViTables is a GUI for browsing and editing files in both
+PyTables and HDF5 formats. ViTables capabilities include easy navigation
+through the data hierarchy, displaying of real data and its associated
+metadata, a simple, yet powerful, browsing of multidimensional data and much
+more. As a viewer, one of the greatest strengths of ViTables is its ability to
+display very large datasets.")
+    (license license:gpl3)))
-- 
2.36.0

Message #8 received at 55188 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Peter Polidoro <peter <at> polidoro.io>
Cc: 55188 <at> debbugs.gnu.org
Subject: Re: bug#55188: [PATCH] gnu: Add python-vitables.
Date: Mon, 09 May 2022 11:29:38 +0200

Hello Peter,

> +    (arguments
> +     `(#:tests? #f))

You should add a comment stating why the tests are disabled. Because
there are no tests or because they are failing, and if so why?

> +    (description "ViTables is a GUI for browsing and editing files in both
> +PyTables and HDF5 formats. ViTables capabilities include easy navigation
> +through the data hierarchy, displaying of real data and its associated
> +metadata, a simple, yet powerful, browsing of multidimensional data and much
> +more. As a viewer, one of the greatest strengths of ViTables is its ability to
> +display very large datasets.")
> +    (license license:gpl3)))

The description could be more neutral: you could remove the "yet
powerful" and "much more" parts. The last sentence could also be
reworded: "As a viewer, ViTables is able to display very large datasets."
feels more factual.

Could you send an updated patch :) ?

Thanks,

Mathieu

Message #11 received at 55188 <at> debbugs.gnu.org (full text, mbox):

From: Peter Polidoro <peter <at> polidoro.io>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 55188 <at> debbugs.gnu.org
Subject: Re: bug#55188: [PATCH] gnu: Add python-vitables.
Date: Thu, 12 May 2022 10:55:57 -0400

[Message part 1 (text/plain, inline)]

Hi,

I have made changes you suggested to the description and have 
attached a new patch, thank you.

I tried to get the tests to run, but they have errors and I do not 
know enough yet to fix them myself:

qt.qpa.xcb: could not connect to display
qt.qpa.plugin: Could not load the Qt platform plugin "xcb" in "" 
even though it was found.

Is it possible to get tests like this to work when building 
packages in isolated environments? Or is it necessary to disable 
these tests?

Thank you for your time!


Mathieu Othacehe <othacehe <at> gnu.org> writes:

> Hello Peter,
>
>> +    (arguments
>> +     `(#:tests? #f))
>
> You should add a comment stating why the tests are disabled. 
> Because
> there are no tests or because they are failing, and if so why?
>
>> +    (description "ViTables is a GUI for browsing and editing 
>> files in both
>> +PyTables and HDF5 formats. ViTables capabilities include easy 
>> navigation
>> +through the data hierarchy, displaying of real data and its 
>> associated
>> +metadata, a simple, yet powerful, browsing of multidimensional 
>> data and much
>> +more. As a viewer, one of the greatest strengths of ViTables 
>> is its ability to
>> +display very large datasets.")
>> +    (license license:gpl3)))
>
> The description could be more neutral: you could remove the "yet
> powerful" and "much more" parts. The last sentence could also be
> reworded: "As a viewer, ViTables is able to display very large 
> datasets."
> feels more factual.
>
> Could you send an updated patch :) ?
>
> Thanks,
>
> Mathieu

[0001-gnu-Add-python-vitables.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.