GNU bug report logs - #55188
[PATCH] gnu: Add python-vitables.

Previous Next

Package: guix-patches;

Reported by: Peter Polidoro <peter <at> polidoro.io>

Date: Fri, 29 Apr 2022 17:16:01 UTC

Severity: normal

Tags: patch

Full log


View this message in rfc822 format

From: Peter Polidoro <peter <at> polidoro.io>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 55188 <at> debbugs.gnu.org
Subject: [bug#55188] [PATCH] gnu: Add python-vitables.
Date: Thu, 12 May 2022 10:55:57 -0400
[Message part 1 (text/plain, inline)]
Hi,

I have made changes you suggested to the description and have 
attached a new patch, thank you.

I tried to get the tests to run, but they have errors and I do not 
know enough yet to fix them myself:

qt.qpa.xcb: could not connect to display
qt.qpa.plugin: Could not load the Qt platform plugin "xcb" in "" 
even though it was found.

Is it possible to get tests like this to work when building 
packages in isolated environments? Or is it necessary to disable 
these tests?

Thank you for your time!


Mathieu Othacehe <othacehe <at> gnu.org> writes:

> Hello Peter,
>
>> +    (arguments
>> +     `(#:tests? #f))
>
> You should add a comment stating why the tests are disabled. 
> Because
> there are no tests or because they are failing, and if so why?
>
>> +    (description "ViTables is a GUI for browsing and editing 
>> files in both
>> +PyTables and HDF5 formats. ViTables capabilities include easy 
>> navigation
>> +through the data hierarchy, displaying of real data and its 
>> associated
>> +metadata, a simple, yet powerful, browsing of multidimensional 
>> data and much
>> +more. As a viewer, one of the greatest strengths of ViTables 
>> is its ability to
>> +display very large datasets.")
>> +    (license license:gpl3)))
>
> The description could be more neutral: you could remove the "yet
> powerful" and "much more" parts. The last sentence could also be
> reworded: "As a viewer, ViTables is able to display very large 
> datasets."
> feels more factual.
>
> Could you send an updated patch :) ?
>
> Thanks,
>
> Mathieu

[0001-gnu-Add-python-vitables.patch (text/x-diff, attachment)]

This bug report was last modified 3 years and 33 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.