GNU bug report logs - #55
SYNC_INPUT and 23.1.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55 in the body.
You can then email your comments to 55 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: YAMAMOTO Mitsuharu <mituharu <at> math.s.chiba-u.ac.jp>
To: rms <at> gnu.org
Cc: jan.h.d <at> swipnet.se, monnier <at> iro.umontreal.ca, emacs-devel <at> gnu.org
Subject: Re: SYNC_INPUT and 23.1.
Date: Thu, 13 Mar 2008 09:44:48 +0900

>>>>> On Wed, 12 Mar 2008 13:51:35 -0400, Richard Stallman <rms <at> gnu.org> said:

>     Even with SYNC_INPUT, atimer functions (except poll_for_input)
>     may still call malloc in the signal handler context.  So
>     emacs_blocked_malloc etc. were actually meaningful even in
>     SYNC_INPUT environments.

> Why is that?  Can it be eliminated?

Here's the list of atimer functions (the third argument to
start_atimer):

  xg_process_timeouts, poll_for_input, show_hourglass,
  create_process_1, x_process_timeouts

Among them, show_hourglass, x_process_timeouts, and
xg_process_timeouts will call async-signal unsafe functions.

I think show_hourglass can be deferred until the next QUIT.  But not
sure about x_process_timeouts and xg_process_timeouts.

				     YAMAMOTO Mitsuharu
				mituharu <at> math.s.chiba-u.ac.jp

Message #10 received at 55-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Jan Djärv <jan.h.d <at> swipnet.se>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: YAMAMOTO Mitsuharu <mituharu <at> math.s.chiba-u.ac.jp>, emacs-devel <at> gnu.org
Subject: Re: SYNC_INPUT and 23.1.
Date: Wed, 09 Apr 2008 08:50:17 +0200

Stefan Monnier skrev:
>>> Sinc there has been no objections, I enabled this by default.  You
>>> can pass --disable-sync-input to configure if there is problems.
>>> But I guess we soon will start take advantage of sync input so the
>>> disabled case will become obsolete.  When we feel confident that
>>> sync input works, I'll remove the non-sync-input code.
> 
>> Even with SYNC_INPUT, atimer functions (except poll_for_input)
>> may still call malloc in the signal handler context.
> 
> That needs to be fixed, then.
> 

I've changed atimers so they are not called in signal handler context.

	Jan D.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.