GNU bug report logs - #54970
28.1; Some emoji no longer display

Previous Next

Full log

View this message in rfc822 format

From: Alan Third <alan <at> idiocy.org>
To: Eli Zaretskii <eliz <at> gnu.org>, Lars Ingebrigtsen <larsi <at> gnus.org>, hmelman <at> gmail.com, rpluim <at> gmail.com, 54970 <at> debbugs.gnu.org
Subject: bug#54970: 28.1; Some emoji no longer display
Date: Sun, 17 Apr 2022 21:34:52 +0100

[Message part 1 (text/plain, inline)]

On Sun, Apr 17, 2022 at 08:47:07PM +0100, Alan Third wrote:
> On Sun, Apr 17, 2022 at 08:27:45PM +0100, Alan Third wrote:
> > On Sun, Apr 17, 2022 at 09:58:56PM +0300, Eli Zaretskii wrote:
> > > No idea.  Maybe it's a macOS thing or something?
> > 
> > I'm pretty sure that I've never ever seen NS Emacs on macOS produce
> > anything but a blank square (and it's always a square) for missing
> > characters.
> 
> Hmm, in fact, is this, from nsterm.m, the culprit?
> 
>     case GLYPHLESS_GLYPH:
>       if (s->for_overlaps || (s->cmp_from > 0
> 			      && ! s->first_glyph->u.cmp.automatic))
>         s->background_filled_p = 1;
>       else
>         ns_maybe_dumpglyphs_background
>           (s, s->first_glyph->type == COMPOSITE_GLYPH);
>       /* ... */
>       /* Not yet implemented.  */
>       /* ... */
>       break;

To answer my own question: yes. Yes it is.

Patch attached.

It doesn't look to me like it displays quite right, the right hand
side of the hex code gets cut off on my Mac and under GNUstep only the
first line is displayed, but I can't see any reason for it.

Maybe this is better than nothing, though.

-- 
Alan Third

[0001-Fix-glyphless-glyph-display-on-NS-bug-54970.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.