GNU bug report logs - #54932
28.1; electric-help doesn't work when `help-char' has meta-prefix

Previous Next

Package: emacs;

Reported by: Nobuyoshi Nakada <nobu.nakada <at> gmail.com>

Date: Thu, 14 Apr 2022 10:49:02 UTC

Severity: normal

Found in version 28.1

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: Nobuyoshi Nakada <nobu.nakada <at> gmail.com>, 54932 <at> debbugs.gnu.org
Subject: bug#54932: 28.1; electric-help doesn't work when `help-char' has meta-prefix
Date: Thu, 14 Apr 2022 14:39:12 -0700

Hello,

On Thu 14 Apr 2022 at 06:04PM +09, Nobuyoshi Nakada wrote:

> --- 28.1/lisp/ehelp.el.gz
> +++ site-lisp/ehelp.el.gz
> @@ -76,7 +76,9 @@
>      (define-key map [?\C-7] 'electric-help-undefined)
>      (define-key map [?\C-8] 'electric-help-undefined)
>      (define-key map [?\C-9] 'electric-help-undefined)
> -    (define-key map (char-to-string help-char) 'electric-help-help)
> +    (define-key map
> +      (if (characterp help-char) (char-to-string help-char) (vector help-char))
> +      'electric-help-help)
>      (define-key map "?" 'electric-help-help)
>      (define-key map " " 'scroll-up)
>      (define-key map [?\S-\ ] 'scroll-down)

Couldn't `vector' be used unconditionally?

-- 
Sean Whitton
This bug report was last modified 3 years and 42 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.