GNU bug report logs - #54931
[PATCH] Have submit-emacs-patch prompt for patch file before subject

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 54931 in the body.
You can then email your comments to 54931 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Have submit-emacs-patch prompt for patch file before subject
Date: Thu, 14 Apr 2022 10:16:11 +0000

[Message part 1 (text/plain, inline)]

Tags: patch


When sending patches using submit-emacs-patch, I usually want to reuse
the commit title for the message subject.  As a minor convenience, this
can be guessed when the patch file is prompted before the subject,
allowing for a default value to be provided by extracting the "Subject"
header from the patch file.

In GNU Emacs 29.0.50 (build 4, x86_64-pc-linux-gnu, GTK+ Version 3.24.30, cairo version 1.16.0)
 of 2022-04-10 built on viero
Repository revision: 0023cfdc4e6d348519198cf75553d1afad0ed153
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: Guix System

Configured using:
 'configure
 PKG_CONFIG_PATH=/home/philip/.guix-profile/lib/pkgconfig:/home/philip/.guix-profile/share/pkgconfig'

[0001-Have-submit-emacs-patch-prompt-for-patch-file-before.patch (text/patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 
	Philip Kaludercic

Message #8 received at 54931 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: 54931 <at> debbugs.gnu.org
Subject: Re: bug#54931: [PATCH] Have submit-emacs-patch prompt for patch
 file before subject
Date: Thu, 14 Apr 2022 15:52:43 +0200

Philip Kaludercic <philipk <at> posteo.net> writes:

> When sending patches using submit-emacs-patch, I usually want to reuse
> the commit title for the message subject.  As a minor convenience, this
> can be guessed when the patch file is prompted before the subject,
> allowing for a default value to be provided by extracting the "Subject"
> header from the patch file.

Looks good to me, please go ahead and push.

> +     (list (read-string (format-prompt "This patch is about" guess )
> +                        nil nil guess)

But without that space between "guess" and ")".  

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 54931 <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 54931 <at> debbugs.gnu.org
Subject: Re: bug#54931: [PATCH] Have submit-emacs-patch prompt for patch
 file before subject
Date: Thu, 14 Apr 2022 16:41:08 +0000

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Philip Kaludercic <philipk <at> posteo.net> writes:
>
>> When sending patches using submit-emacs-patch, I usually want to reuse
>> the commit title for the message subject.  As a minor convenience, this
>> can be guessed when the patch file is prompted before the subject,
>> allowing for a default value to be provided by extracting the "Subject"
>> header from the patch file.
>
> Looks good to me, please go ahead and push.

Done,

>> +     (list (read-string (format-prompt "This patch is about" guess )
>> +                        nil nil guess)
>
> But without that space between "guess" and ")".  

done,

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Philip Kaludercic <philipk <at> posteo.net> writes:
>
>> Reading through time_cmp, I didn't understand why the lisp_time struct
>> was calculated for the first argument before checking if both are eq.
>>>From what I see lisp_time struct is not a destructive function, so it
>> should be possible to call the function when calculating the lisp_time
>> struct for the second argument.
>
> Looks good to me; please go ahead and push.

and done.

-- 
	Philip Kaludercic

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.