GNU bug report logs - #54931
[PATCH] Have submit-emacs-patch prompt for patch file before subject

Previous Next

Full log

Message #11 received at 54931 <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 54931 <at> debbugs.gnu.org
Subject: Re: bug#54931: [PATCH] Have submit-emacs-patch prompt for patch
 file before subject
Date: Thu, 14 Apr 2022 16:41:08 +0000

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Philip Kaludercic <philipk <at> posteo.net> writes:
>
>> When sending patches using submit-emacs-patch, I usually want to reuse
>> the commit title for the message subject.  As a minor convenience, this
>> can be guessed when the patch file is prompted before the subject,
>> allowing for a default value to be provided by extracting the "Subject"
>> header from the patch file.
>
> Looks good to me, please go ahead and push.

Done,

>> +     (list (read-string (format-prompt "This patch is about" guess )
>> +                        nil nil guess)
>
> But without that space between "guess" and ")".  

done,

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Philip Kaludercic <philipk <at> posteo.net> writes:
>
>> Reading through time_cmp, I didn't understand why the lisp_time struct
>> was calculated for the first argument before checking if both are eq.
>>>From what I see lisp_time struct is not a destructive function, so it
>> should be possible to call the function when calculating the lisp_time
>> struct for the second argument.
>
> Looks good to me; please go ahead and push.

and done.

-- 
	Philip Kaludercic

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.