GNU bug report logs - #54930
[PATCH] Avoid possibly unnecessary lisp_time_struct call

Previous Next

Package: emacs;

Reported by: Philip Kaludercic <philipk <at> posteo.net>

Date: Thu, 14 Apr 2022 10:13:01 UTC

Severity: normal

Tags: patch

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: 54930 <at> debbugs.gnu.org
Subject: bug#54930: [PATCH] Avoid possibly unnecessary lisp_time_struct call
Date: Thu, 14 Apr 2022 15:54:02 +0200

Philip Kaludercic <philipk <at> posteo.net> writes:

> Reading through time_cmp, I didn't understand why the lisp_time struct
> was calculated for the first argument before checking if both are eq.
>>From what I see lisp_time struct is not a destructive function, so it
> should be possible to call the function when calculating the lisp_time
> struct for the second argument.

Looks good to me; please go ahead and push.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
This bug report was last modified 3 years and 41 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.