GNU bug report logs - #54930
[PATCH] Avoid possibly unnecessary lisp_time_struct call

Previous Next

Package: emacs;

Reported by: Philip Kaludercic <philipk <at> posteo.net>

Date: Thu, 14 Apr 2022 10:13:01 UTC

Severity: normal

Tags: patch

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Philip Kaludercic <philipk <at> posteo.net>
To: 54930 <at> debbugs.gnu.org
Subject: bug#54930: [PATCH] Avoid possibly unnecessary lisp_time_struct call
Date: Thu, 14 Apr 2022 10:12:03 +0000
[Message part 1 (text/plain, inline)]
Tags: patch


Reading through time_cmp, I didn't understand why the lisp_time struct
was calculated for the first argument before checking if both are eq.
From what I see lisp_time struct is not a destructive function, so it
should be possible to call the function when calculating the lisp_time
struct for the second argument.

In GNU Emacs 29.0.50 (build 4, x86_64-pc-linux-gnu, GTK+ Version 3.24.30, cairo version 1.16.0)
 of 2022-04-10 built on viero
Repository revision: 0023cfdc4e6d348519198cf75553d1afad0ed153
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: Guix System

Configured using:
 'configure
 PKG_CONFIG_PATH=/home/philip/.guix-profile/lib/pkgconfig:/home/philip/.guix-profile/share/pkgconfig'

[0001-Avoid-possibly-unnecessary-lisp_time_struct-call.patch (text/patch, attachment)]
[Message part 3 (text/plain, inline)]
-- 
	Philip Kaludercic

This bug report was last modified 3 years and 41 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.