GNU bug report logs - #54633
[PATCH] * configure.ac: Fix --without-gif for W32, NS, Haiku, and PGTK.

Previous Next

Full log

Message #14 received at 54633 <at> debbugs.gnu.org (full text, mbox):

From: Randy Taylor <dev <at> rjt.dev>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 54633 <at> debbugs.gnu.org
Subject: Re: bug#54633: [PATCH] * configure.ac: Fix --without-gif for W32, NS,
 Haiku, and PGTK.
Date: Wed, 30 Mar 2022 12:42:54 +0000

When I build Emacs I specify "--without-gif".

When using PGTK:
  - With the original code and specifying "--without-gif", here is what configure gives me: Does Emacs use a gif library?                           yes -lgif
  - With the patch and specifying "--without-gif", I get this (as expected): Does Emacs use a gif library?                           no
  - With the patch, if I remove "--without-gif" or specify "--with-gif=yes", I get this (as expected): Does Emacs use a gif library?                           yes -lgif

When using X11:
  - With the original code and specifying "--without-gif", here is what configure gives me (as expected): Does Emacs use a gif library?                           no
  - With the original code and removing "--without-gif" or specifying "--with-gif="yes", here is what configure gives me (as expected): Does Emacs use a gif library?                           yes -lgif

The check in the code for "--without-gif" only applies to X11, but not the other systems.
This patch fixes it to apply for all the systems in that check, in the same fashion as the SVG check (see line 2660 in configure.ac).

------- Original Message -------

On Wednesday, March 30th, 2022 at 08:13, Eli Zaretskii <eliz <at> gnu.org> wrote:

> > Date: Wed, 30 Mar 2022 01:45:16 +0000
>
> > From: Randy Taylor dev <at> rjt.dev
> >
> > --without-gif was only checked against X11; with this patch it is now checked against all the options.
>
> Please describe the problem you had with the current code. Because I
>
> don't think I see the problem you are trying to fix.
>
> Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.