GNU bug report logs - #54633
[PATCH] * configure.ac: Fix --without-gif for W32, NS, Haiku, and PGTK.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 54633 in the body.
You can then email your comments to 54633 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Randy Taylor <dev <at> rjt.dev>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: [PATCH] * configure.ac: Fix --without-gif for W32, NS, Haiku,
 and PGTK.
Date: Wed, 30 Mar 2022 01:45:16 +0000

[Message part 1 (text/plain, inline)]

--without-gif was only checked against X11; with this patch it is now checked against all the options.

[Message part 2 (text/html, inline)]

[0001-configure.ac-Fix-without-gif-for-W32-NS-Haiku-and-PG.patch (text/x-patch, attachment)]

Message #8 received at 54633 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Randy Taylor <dev <at> rjt.dev>
Cc: 54633 <at> debbugs.gnu.org
Subject: Re: bug#54633: [PATCH] * configure.ac: Fix --without-gif for W32,
 NS, Haiku, and PGTK.
Date: Wed, 30 Mar 2022 13:31:17 +0800

Randy Taylor <dev <at> rjt.dev> writes:

> --without-gif was only checked against X11; with this patch it is now
> checked against all the options.

That might've been intentional, I think there was a discussion about
optional image libraries and w32 some time ago.

Message #11 received at 54633 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Randy Taylor <dev <at> rjt.dev>
Cc: 54633 <at> debbugs.gnu.org
Subject: Re: bug#54633: [PATCH] * configure.ac: Fix --without-gif for W32, NS, 
 Haiku, and PGTK.
Date: Wed, 30 Mar 2022 15:13:22 +0300

> Date: Wed, 30 Mar 2022 01:45:16 +0000
> From: Randy Taylor <dev <at> rjt.dev>
> 
> --without-gif was only checked against X11; with this patch it is now checked against all the options.

Please describe the problem you had with the current code.  Because I
don't think I see the problem you are trying to fix.

Thanks.

Message #14 received at 54633 <at> debbugs.gnu.org (full text, mbox):

From: Randy Taylor <dev <at> rjt.dev>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 54633 <at> debbugs.gnu.org
Subject: Re: bug#54633: [PATCH] * configure.ac: Fix --without-gif for W32, NS,
 Haiku, and PGTK.
Date: Wed, 30 Mar 2022 12:42:54 +0000

When I build Emacs I specify "--without-gif".

When using PGTK:
  - With the original code and specifying "--without-gif", here is what configure gives me: Does Emacs use a gif library?                           yes -lgif
  - With the patch and specifying "--without-gif", I get this (as expected): Does Emacs use a gif library?                           no
  - With the patch, if I remove "--without-gif" or specify "--with-gif=yes", I get this (as expected): Does Emacs use a gif library?                           yes -lgif

When using X11:
  - With the original code and specifying "--without-gif", here is what configure gives me (as expected): Does Emacs use a gif library?                           no
  - With the original code and removing "--without-gif" or specifying "--with-gif="yes", here is what configure gives me (as expected): Does Emacs use a gif library?                           yes -lgif

The check in the code for "--without-gif" only applies to X11, but not the other systems.
This patch fixes it to apply for all the systems in that check, in the same fashion as the SVG check (see line 2660 in configure.ac).

------- Original Message -------

On Wednesday, March 30th, 2022 at 08:13, Eli Zaretskii <eliz <at> gnu.org> wrote:

> > Date: Wed, 30 Mar 2022 01:45:16 +0000
>
> > From: Randy Taylor dev <at> rjt.dev
> >
> > --without-gif was only checked against X11; with this patch it is now checked against all the options.
>
> Please describe the problem you had with the current code. Because I
>
> don't think I see the problem you are trying to fix.
>
> Thanks.

Message #17 received at 54633 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Randy Taylor <dev <at> rjt.dev>, Po Lu <luangruo <at> yahoo.com>
Cc: 54633 <at> debbugs.gnu.org
Subject: Re: bug#54633: [PATCH] * configure.ac: Fix --without-gif for W32, NS,
 Haiku, and PGTK.
Date: Wed, 30 Mar 2022 16:27:02 +0300

> Date: Wed, 30 Mar 2022 12:42:54 +0000
> From: Randy Taylor <dev <at> rjt.dev>
> Cc: 54633 <at> debbugs.gnu.org
> 
> When I build Emacs I specify "--without-gif".
> 
> When using PGTK:
>   - With the original code and specifying "--without-gif", here is what configure gives me: Does Emacs use a gif library?                           yes -lgif
>   - With the patch and specifying "--without-gif", I get this (as expected): Does Emacs use a gif library?                           no
>   - With the patch, if I remove "--without-gif" or specify "--with-gif=yes", I get this (as expected): Does Emacs use a gif library?                           yes -lgif
> 
> When using X11:
>   - With the original code and specifying "--without-gif", here is what configure gives me (as expected): Does Emacs use a gif library?                           no
>   - With the original code and removing "--without-gif" or specifying "--with-gif="yes", here is what configure gives me (as expected): Does Emacs use a gif library?                           yes -lgif
> 
> The check in the code for "--without-gif" only applies to X11, but not the other systems.
> This patch fixes it to apply for all the systems in that check, in the same fashion as the SVG check (see line 2660 in configure.ac).

Thanks.  But your patch touched more than just the PGTK build.  For
w32, for example, I see no reason to make any changes; do you?
Likewise for NS.

Po Lu, do you agree that only PGTK needs a fix?  If co, can you
suggest a fix for PGTK only?

Message #20 received at 54633 <at> debbugs.gnu.org (full text, mbox):

From: Randy Taylor <dev <at> rjt.dev>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Po Lu <luangruo <at> yahoo.com>, 54633 <at> debbugs.gnu.org
Subject: Re: bug#54633: [PATCH] * configure.ac: Fix --without-gif for W32, NS,
 Haiku, and PGTK.
Date: Wed, 30 Mar 2022 13:34:22 +0000

------- Original Message -------

On Wednesday, March 30th, 2022 at 09:27, Eli Zaretskii <eliz <at> gnu.org> wrote:

> > Date: Wed, 30 Mar 2022 12:42:54 +0000
>
> > From: Randy Taylor dev <at> rjt.dev
> >
> > Cc: 54633 <at> debbugs.gnu.org
> >
> > When I build Emacs I specify "--without-gif".
> >
> > When using PGTK:
> >
> > - With the original code and specifying "--without-gif", here is what configure gives me: Does Emacs use a gif library? yes -lgif
> >
> > - With the patch and specifying "--without-gif", I get this (as expected): Does Emacs use a gif library? no
> >
> > - With the patch, if I remove "--without-gif" or specify "--with-gif=yes", I get this (as expected): Does Emacs use a gif library? yes -lgif
> >
> > When using X11:
> >
> > - With the original code and specifying "--without-gif", here is what configure gives me (as expected): Does Emacs use a gif library? no
> >
> > - With the original code and removing "--without-gif" or specifying "--with-gif="yes", here is what configure gives me (as expected): Does Emacs use a gif library? yes -lgif
> >
> > The check in the code for "--without-gif" only applies to X11, but not the other systems.
> >
> > This patch fixes it to apply for all the systems in that check, in the same fashion as the SVG check (see line 2660 in configure.ac).
>
> Thanks. But your patch touched more than just the PGTK build. For
>
> w32, for example, I see no reason to make any changes; do you?
>
> Likewise for NS.
>
> Po Lu, do you agree that only PGTK needs a fix? If co, can you
>
> suggest a fix for PGTK only?

If someone specifies "--without-gif", then Emacs should not build with gif support. That is why I made the check to apply for all systems. The same behaviour already applies to all the other formats, like SVG which I mentioned.

Message #23 received at 54633 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Randy Taylor <dev <at> rjt.dev>, 54633 <at> debbugs.gnu.org
Subject: Re: bug#54633: [PATCH] * configure.ac: Fix --without-gif for W32,
 NS, Haiku, and PGTK.
Date: Wed, 30 Mar 2022 21:34:25 +0800

Eli Zaretskii <eliz <at> gnu.org> writes:

> Thanks.  But your patch touched more than just the PGTK build.  For
> w32, for example, I see no reason to make any changes; do you?
> Likewise for NS.
>
> Po Lu, do you agree that only PGTK needs a fix?  If co, can you
> suggest a fix for PGTK only?

I didn't yet test this, but it should work correctly.  Randy, please
test.  Thanks.

Native image APIs are used on Haiku and NS for GIF image support, so
this probably doesn't have to change.

diff --git a/configure.ac b/configure.ac
index 93c821eda0..99b2ecc669 100644
--- a/configure.ac
+++ b/configure.ac
@@ -4292,7 +4292,8 @@ AC_DEFUN
   fi
 elif test "${HAVE_X11}" = "yes" && test "${with_gif}" != "no" \
         || test "${HAVE_W32}" = "yes" || test "${HAVE_NS}" = "yes" \
-	|| test "${HAVE_BE_APP}" = "yes" || test "$window_system" = "pgtk"; then
+	|| test "${HAVE_BE_APP}" = "yes" || test "$window_system" = "pgtk" \
+	&& test "${with_gif}" != "no"; then
   AC_CHECK_HEADER(gif_lib.h,
 # EGifPutExtensionLast only exists from version libungif-4.1.0b1.
 # Earlier versions can crash Emacs, but version 5.0 removes EGifPutExtensionLast.

Message #26 received at 54633 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Randy Taylor <dev <at> rjt.dev>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 54633 <at> debbugs.gnu.org
Subject: Re: bug#54633: [PATCH] * configure.ac: Fix --without-gif for W32,
 NS, Haiku, and PGTK.
Date: Wed, 30 Mar 2022 21:39:36 +0800

Randy Taylor <dev <at> rjt.dev> writes:

> If someone specifies "--without-gif", then Emacs should not build with
> gif support. That is why I made the check to apply for all
> systems. The same behaviour already applies to all the other formats,
> like SVG which I mentioned.

Emacs built without libgif on NS or Haiku will still result in a build
that can display GIF files, since native image APIs are enabled by
default on both those platforms.  (On Haiku the relevant translator also
has to be installed, but it comes in a default installation.)

Message #29 received at 54633 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Randy Taylor <dev <at> rjt.dev>
Cc: luangruo <at> yahoo.com, 54633 <at> debbugs.gnu.org
Subject: Re: bug#54633: [PATCH] * configure.ac: Fix --without-gif for W32, NS,
 Haiku, and PGTK.
Date: Wed, 30 Mar 2022 16:46:48 +0300

> Date: Wed, 30 Mar 2022 13:34:22 +0000
> From: Randy Taylor <dev <at> rjt.dev>
> Cc: Po Lu <luangruo <at> yahoo.com>, 54633 <at> debbugs.gnu.org
> 
> If someone specifies "--without-gif", then Emacs should not build
> with gif support.

Only on systems where --without-gif indeed removes the GIF support.
For example, if GIF support is built-in with native image display,
then using --without-gif is meaningless.

Message #32 received at 54633 <at> debbugs.gnu.org (full text, mbox):

From: Randy Taylor <dev <at> rjt.dev>
To: Po Lu <luangruo <at> yahoo.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 54633 <at> debbugs.gnu.org
Subject: Re: bug#54633: [PATCH] * configure.ac: Fix --without-gif for W32, NS,
 Haiku, and PGTK.
Date: Wed, 30 Mar 2022 14:55:42 +0000

------- Original Message -------

On Wednesday, March 30th, 2022 at 09:34, Po Lu <luangruo <at> yahoo.com> wrote:

> Eli Zaretskii eliz <at> gnu.org writes:
>
> > Thanks. But your patch touched more than just the PGTK build. For
> >
> > w32, for example, I see no reason to make any changes; do you?
> >
> > Likewise for NS.
> >
> > Po Lu, do you agree that only PGTK needs a fix? If co, can you
> >
> > suggest a fix for PGTK only?
>
> I didn't yet test this, but it should work correctly. Randy, please
>
> test. Thanks.
>
> Native image APIs are used on Haiku and NS for GIF image support, so
>
> this probably doesn't have to change.
>
> diff --git a/configure.ac b/configure.ac
>
> index 93c821eda0..99b2ecc669 100644
>
> --- a/configure.ac
>
> +++ b/configure.ac
>
> @@ -4292,7 +4292,8 @@ AC_DEFUN
>
> fi
>
> elif test "${HAVE_X11}" = "yes" && test "${with_gif}" != "no" \
>
> || test "${HAVE_W32}" = "yes" || test "${HAVE_NS}" = "yes" \
>
> - || test "${HAVE_BE_APP}" = "yes" || test "$window_system" = "pgtk"; then
>
> + || test "${HAVE_BE_APP}" = "yes" || test "$window_system" = "pgtk" \
>
> + && test "${with_gif}" != "no"; then
>
> AC_CHECK_HEADER(gif_lib.h,
>
> # EGifPutExtensionLast only exists from version libungif-4.1.0b1.
>
> # Earlier versions can crash Emacs, but version 5.0 removes EGifPutExtensionLast.

Works for me. Makes sense to only apply it to PGTK.

Thanks.

Message #35 received at 54633 <at> debbugs.gnu.org (full text, mbox):

From: Randy Taylor <dev <at> rjt.dev>
To: Po Lu <luangruo <at> yahoo.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 54633 <at> debbugs.gnu.org
Subject: Re: bug#54633: [PATCH] * configure.ac: Fix --without-gif for W32, NS,
 Haiku, and PGTK.
Date: Mon, 04 Apr 2022 14:09:21 +0000

Anything stopping this from going in?


------- Original Message -------
On Wednesday, March 30th, 2022 at 10:55, Randy Taylor <dev <at> rjt.dev> wrote:


>
>
>
>
> ------- Original Message -------
>
> On Wednesday, March 30th, 2022 at 09:34, Po Lu luangruo <at> yahoo.com wrote:
>
> > Eli Zaretskii eliz <at> gnu.org writes:
> >
> > > Thanks. But your patch touched more than just the PGTK build. For
> > >
> > > w32, for example, I see no reason to make any changes; do you?
> > >
> > > Likewise for NS.
> > >
> > > Po Lu, do you agree that only PGTK needs a fix? If co, can you
> > >
> > > suggest a fix for PGTK only?
> >
> > I didn't yet test this, but it should work correctly. Randy, please
> >
> > test. Thanks.
> >
> > Native image APIs are used on Haiku and NS for GIF image support, so
> >
> > this probably doesn't have to change.
> >
> > diff --git a/configure.ac b/configure.ac
> >
> > index 93c821eda0..99b2ecc669 100644
> >
> > --- a/configure.ac
> >
> > +++ b/configure.ac
> >
> > @@ -4292,7 +4292,8 @@ AC_DEFUN
> >
> > fi
> >
> > elif test "${HAVE_X11}" = "yes" && test "${with_gif}" != "no" \
> >
> > || test "${HAVE_W32}" = "yes" || test "${HAVE_NS}" = "yes" \
> >
> > - || test "${HAVE_BE_APP}" = "yes" || test "$window_system" = "pgtk"; then
> >
> > + || test "${HAVE_BE_APP}" = "yes" || test "$window_system" = "pgtk" \
> >
> > + && test "${with_gif}" != "no"; then
> >
> > AC_CHECK_HEADER(gif_lib.h,
> >
> > # EGifPutExtensionLast only exists from version libungif-4.1.0b1.
> >
> > # Earlier versions can crash Emacs, but version 5.0 removes EGifPutExtensionLast.
>
>
> Works for me. Makes sense to only apply it to PGTK.
>
> Thanks.

Message #40 received at 54633-done <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Randy Taylor <dev <at> rjt.dev>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 54633-done <at> debbugs.gnu.org
Subject: Re: bug#54633: [PATCH] * configure.ac: Fix --without-gif for W32,
 NS, Haiku, and PGTK.
Date: Tue, 05 Apr 2022 09:08:26 +0800

Randy Taylor <dev <at> rjt.dev> writes:

> Anything stopping this from going in?

No, sorry.  I installed it and am closing this bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.