GNU bug report logs - #54588
29.0.50; [PATCH] Don't use `eshell-convert' when not needed / Fix setting umask in Eshell

Previous Next

Full log

Message #8 received at 54588 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: 54588 <at> debbugs.gnu.org
Subject: Re: bug#54588: 29.0.50; [PATCH] Don't use `eshell-convert' when not
 needed / Fix setting umask in Eshell
Date: Tue, 29 Mar 2022 16:51:36 +0200

Jim Porter <jporterbugs <at> gmail.com> writes:

> In my patch, the behavior is changed as follows. First, when calling
> `umask 222', the "222" is passed as a string, with no
> conversion. Next, `eshell-eval-using-options' is set to preserve
> arguments, so if you pass an actual number (as in `umask $(identity
> #o222)'), it doesn't try to stringify it. Then, if the argument is a
> string, `eshell/umask' converts it to an octal number. Finally, the
> numeric argument is used to set the umask.
>
> I also simplified the code for printing the umask a bit. That part
> just splits the symbolic and non-symbolic cases up so there's less
> duplicated work, plus simplifies the `format' call for the
> non-symbolic case.

Makes sense to me; pushed to Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.