GNU bug report logs - #54589
[PATCH] gnu: emacs-geiser: Update to 0.23.1.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 54589 in the body.
You can then email your comments to 54589 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Olivier Dion <olivier.dion <at> polymtl.ca>
To: guix-patches <at> gnu.org
Cc: Olivier Dion <olivier.dion <at> polymtl.ca>
Subject: [PATCH] gnu: emacs-geiser: Update to 0.23.1.
Date: Sat, 26 Mar 2022 19:11:15 -0400

* gnu/packages/emacs-xyz.scm (emacs-geiser): Update to 0.23.1.
[propagated-inputs]: Add emacs-project.
---
 gnu/packages/emacs-xyz.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 42fc13f4c2..57a2f574c5 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -271,7 +271,7 @@ (define-public emacs-geiser
     (native-inputs
      (list texinfo))
     (propagated-inputs
-     (list emacs-transient))
+     (list emacs-project emacs-transient))
     (home-page "https://nongnu.org/geiser/")
     (synopsis "Collection of Emacs modes for Scheme hacking")
     (description
-- 
2.34.0

Message #8 received at 54589 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Olivier Dion <olivier.dion <at> polymtl.ca>
Cc: 54589 <at> debbugs.gnu.org
Subject: Re: bug#54589: [PATCH] gnu: emacs-geiser: Update to 0.23.1.
Date: Tue, 29 Mar 2022 11:29:49 +0200

Hi,

Olivier Dion <olivier.dion <at> polymtl.ca> skribis:

> * gnu/packages/emacs-xyz.scm (emacs-geiser): Update to 0.23.1.
> [propagated-inputs]: Add emacs-project.

I suppose the emacs-geiser-* packages should be updated at the same
time, shouldn’t they?

Could you send an updated patch that does that too?

Thanks,
Ludo’.

Message #13 received at 54589 <at> debbugs.gnu.org (full text, mbox):

From: Olivier Dion <olivier.dion <at> polymtl.ca>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 54589 <at> debbugs.gnu.org
Subject: Re: bug#54589: [PATCH] gnu: emacs-geiser: Update to 0.23.1.
Date: Tue, 05 Apr 2022 21:16:32 -0400

On Tue, 29 Mar 2022, Ludovic Courtès <ludo <at> gnu.org> wrote:
> Hi,

Sorry for the long delay.

> Olivier Dion <olivier.dion <at> polymtl.ca> skribis:
>
>> * gnu/packages/emacs-xyz.scm (emacs-geiser): Update to 0.23.1.
>> [propagated-inputs]: Add emacs-project.
>
> I suppose the emacs-geiser-* packages should be updated at the same
> time, shouldn’t they?

I don't think so?  Emacs geiser is already bumped at version 0.23.1, but
the commit that introduced that change forgot to add the new dependency
`emacs-project`.

I think that the commit message is confusing, sorry for that.  It should
probably be `Add missing dependency ` and not `Update to ...`.  Let me
know what you think.

-- 
Olivier Dion
oldiob.dev

Message #18 received at 54589-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Olivier Dion <olivier.dion <at> polymtl.ca>
Cc: 54589-done <at> debbugs.gnu.org
Subject: Re: bug#54589: [PATCH] gnu: emacs-geiser: Update to 0.23.1.
Date: Fri, 08 Apr 2022 23:09:31 +0200

Hi,

Olivier Dion <olivier.dion <at> polymtl.ca> skribis:

> I don't think so?  Emacs geiser is already bumped at version 0.23.1, but
> the commit that introduced that change forgot to add the new dependency
> `emacs-project`.
>
> I think that the commit message is confusing, sorry for that.  It should
> probably be `Add missing dependency ` and not `Update to ...`.  Let me
> know what you think.

Indeed, I had overlooked that.  Committed with the commit message
adjusted accordingly.

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.