GNU bug report logs - #54493
27.2; image-convert :data broken

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 54493 in the body.
You can then email your comments to 54493 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: awrhygty <at> outlook.com
To: bug-gnu-emacs <at> gnu.org
Subject: 27.2; image-convert :data broken
Date: Mon, 21 Mar 2022 22:02:12 +0900

I tried to view non-native image files.
I need not only to set variables, but also to modify a function.
The externally converted data is broken by automatic code-conversion.

(setq image-use-external-converter t
      image-converter--converters
      '((imagemagick :command ("magick" "convert")
                     :probe ("-list" "format"))))
(advice-add #'image-converter--convert
            :before (lambda (&rest r) (setq-local coding-system-for-read 'binary)))



In GNU Emacs 27.2 (build 1, x86_64-w64-mingw32)
 of 2021-03-26 built on CIRROCUMULUS
Repository revision: deef5efafb70f4b171265b896505b92b6eef24e6
Repository branch: HEAD
Windowing system distributor 'Microsoft Corp.', version 10.0.19044
System Description: Microsoft Windows 10 Pro (v10.0.2009.19044.1586)

Recent messages:

Configured using:
 'configure --without-dbus --host=x86_64-w64-mingw32
 --without-compress-install 'CFLAGS=-O2 -static''

Configured features:
XPM JPEG TIFF GIF PNG RSVG SOUND NOTIFY W32NOTIFY ACL GNUTLS LIBXML2
HARFBUZZ ZLIB TOOLKIT_SCROLL_BARS MODULES THREADS JSON PDUMPER LCMS2 GMP

Important settings:
  value of $LANG: JPN
  locale-coding-system: cp932

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg
epg-config gnus-util rmail rmail-loaddefs text-property-search time-date
subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs
cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils
term/bobcat japan-util tooltip eldoc electric uniquify ediff-hook
vc-hooks lisp-float-type mwheel dos-w32 ls-lisp disp-table term/w32-win
w32-win w32-vars term/common-win tool-bar dnd fontset image regexp-opt
fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer
select scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese composite charscript charprop case-table epa-hook
jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs
button faces cus-face macroexp files text-properties overlay sha1 md5
base64 format env code-pages mule custom widget hashtable-print-readable
backquote threads w32notify w32 lcms2 multi-tty make-network-process
emacs)

Memory information:
((conses 16 48618 9086)
 (symbols 48 6089 1)
 (strings 32 16924 1180)
 (string-bytes 1 521726)
 (vectors 16 9935)
 (vector-slots 8 201874 8320)
 (floats 8 21 347)
 (intervals 56 210 0)
 (buffers 1000 11))

Message #8 received at 54493 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: awrhygty <at> outlook.com
Cc: 54493 <at> debbugs.gnu.org
Subject: Re: bug#54493: 27.2; image-convert :data broken
Date: Mon, 21 Mar 2022 17:35:07 +0100

awrhygty <at> outlook.com writes:

> I tried to view non-native image files.
> I need not only to set variables, but also to modify a function.
> The externally converted data is broken by automatic code-conversion.

I can reproduce this in Emacs 27.2, but not on the trunk, so it looks
like this has been fixed.  Here's my test case:

(insert-image
 (create-image
  (with-temp-buffer
    (set-buffer-multibyte nil)
    (insert-file-contents "/home/larsi/src/WebKit/LayoutTests/fast/css/resources/bikes.bmp")
    (buffer-string))
  nil t :format 'image/bmp))



-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #13 received at 54493 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 54493 <at> debbugs.gnu.org, awrhygty <at> outlook.com
Subject: Re: bug#54493: 27.2; image-convert :data broken
Date: Mon, 21 Mar 2022 18:59:48 +0200

> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Date: Mon, 21 Mar 2022 17:35:07 +0100
> Cc: 54493 <at> debbugs.gnu.org
> 
> awrhygty <at> outlook.com writes:
> 
> > I tried to view non-native image files.
> > I need not only to set variables, but also to modify a function.
> > The externally converted data is broken by automatic code-conversion.
> 
> I can reproduce this in Emacs 27.2, but not on the trunk, so it looks
> like this has been fixed.  Here's my test case:
> 
> (insert-image
>  (create-image
>   (with-temp-buffer
>     (set-buffer-multibyte nil)
>     (insert-file-contents "/home/larsi/src/WebKit/LayoutTests/fast/css/resources/bikes.bmp")
>     (buffer-string))
>   nil t :format 'image/bmp))

What if you evaluate this first:

  (set-default-coding-systems 'utf-8-dos)

Does it still work for you?  The OP is on MS-Windows, where the
default decodes the CRFL EOLs, something we shouldn't do with image
data.

In general, I believe explicitly binding coding-system-for-read, as
the OP suggested, is better than relying on some code somewhere that
just happens to let this work (on some systems).

Message #16 received at 54493 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 54493 <at> debbugs.gnu.org, awrhygty <at> outlook.com
Subject: Re: bug#54493: 27.2; image-convert :data broken
Date: Mon, 21 Mar 2022 18:14:23 +0100

Eli Zaretskii <eliz <at> gnu.org> writes:

> What if you evaluate this first:
>
>   (set-default-coding-systems 'utf-8-dos)
>
> Does it still work for you?

Yes.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.