GNU bug report logs - #54481
29.0.50; [PATCH] Rewrite hl-line

Previous Next

Package: emacs;

Reported by: dick <dick.r.chiang <at> gmail.com>

Date: Sun, 20 Mar 2022 16:08:01 UTC

Severity: normal

Found in version 29.0.50

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


Message #8 received at 54481 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: dick <dick.r.chiang <at> gmail.com>
Cc: 54481 <at> debbugs.gnu.org
Subject: Re: bug#54481: 29.0.50; [PATCH] Rewrite hl-line
Date: Mon, 21 Mar 2022 16:09:32 +0100
dick <dick.r.chiang <at> gmail.com> writes:

> The fashion of dual global and minor modes, each managing a replica of
> state, has long been outmoded by globalized minor modes (nee
> easy-mmode-define-global-mode) around the turn of the century.

Makes sense to me, so I've applied the patch to Emacs 29.  The one thing
I was unsure about was things like this:

> -(defun hl-line-unload-function ()
> -  "Unload the Hl-Line library."

We normally don't remove functions like this, but just make them
obsolete.  But in this case it seems unlikely to me that anybody would
actually ever use these functions, so I didn't alter that part.  But if
anybody complains, we should take them the normal obsoletion route.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




This bug report was last modified 3 years and 137 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.