GNU bug report logs - #54482
[PATCH] gnu: Add simavr

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 54482 in the body.
You can then email your comments to 54482 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add simavr
Date: Sun, 20 Mar 2022 19:36:39 +0300

[Message part 1 (text/plain, inline)]

Hello,

this patch adds simavr [1] -- an AVR simulator.

Thanks,

- Artyom

References:
1: https://github.com/buserror/simavr

[0001-gnu-Add-simavr.patch (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

-- 
Artyom "avp" Poptsov <poptsov.artyom <at> gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 54482 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>, 54482 <at> debbugs.gnu.org
Subject: Re: [bug#54482] [PATCH] gnu: Add simavr
Date: Sun, 20 Mar 2022 18:30:22 +0100

[Message part 1 (text/plain, inline)]

Artyom V. Poptsov schreef op zo 20-03-2022 om 19:36 [+0300]:
> +  #:use-module (gnu packages autotools)
> +  #:use-module (gnu packages base)
> +  #:use-module (gnu packages bash)
> +  #:use-module (gnu packages avr)

Why is (gnu packages avr) importing (gnu packages avr)?

> +  #:use-module (gnu packages elf)
> +  #:use-module (gnu packages gl)
> +  #:use-module (gnu packages pkg-config)
> +  #:use-module (gnu packages ncurses)
> +  #:use-module (gnu packages version-control)
> +  #:use-module (gnu packages ruby))

I think most users of avr-libc and avr-toolchain don't need simavr,
so WDYT of defining simavr in a separate module to avoid loading
the (gnu packages ruby) module (which has a large closure, including
much of haskell, java) unless actually necessary?  Benefits are lower
memory usage and less startup time.

Long-term, separating modules (*) a bit more would help with avoiding
circular imports (and maybe eventually, making sure imports aren't
circular at compile-time), makings some ideas for making "guix pull"
faster more feasible
<https://lists.gnu.org/archive/html/guix-devel/2022-02/msg00193.html>
and effective.  I don't think any conclusion was reached upon that
though ...

(*) Though in this case, there doesn't appear to be any circularity,
yet.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 54482 <at> debbugs.gnu.org (full text, mbox):

From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 54482 <at> debbugs.gnu.org
Subject: Re: [bug#54482] [PATCH] gnu: Add simavr
Date: Tue, 22 Mar 2022 00:00:56 +0300

[Message part 1 (text/plain, inline)]

Hello Maxime,

thanks for the feedback!

Here's the updated version of the patch.  I decided to move 'simavr'
package to a new 'avr-xyz' module.

- Artyom

[0001-gnu-avr-xyz-Add-simavr.patch (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

-- 
Artyom "avp" Poptsov <poptsov.artyom <at> gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 54482-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
Cc: 54482-done <at> debbugs.gnu.org, Maxime Devos <maximedevos <at> telenet.be>
Subject: Re: bug#54482: [PATCH] gnu: Add simavr
Date: Thu, 24 Mar 2022 12:58:41 +0100

[Message part 1 (text/plain, inline)]

Hi Artyom,

"Artyom V. Poptsov" <poptsov.artyom <at> gmail.com> skribis:

> From 2ea020a319f5c2fa27662a8e505a1d4b8e916ea9 Mon Sep 17 00:00:00 2001
> From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
> Date: Sat, 19 Mar 2022 23:39:54 +0300
> Subject: [PATCH] gnu: avr-xyz: Add simavr
>
> * gnu/packages/avr-xyz.scm: New module.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add 'avr-xyz.scm'.

Applied with the cosmetic changes below.

Thank you and thanks Maxime!

Ludo’.

[Message part 2 (text/x-patch, inline)]

diff --git a/gnu/packages/avr-xyz.scm b/gnu/packages/avr-xyz.scm
index 800f8af21e..a05157ede7 100644
--- a/gnu/packages/avr-xyz.scm
+++ b/gnu/packages/avr-xyz.scm
@@ -83,9 +83,9 @@ (define-public simavr
     (inputs
      (list bash-minimal libelf freeglut))
     (home-page "https://github.com/buserror/simavr")
-    (synopsis "Lean, mean and hackable AVR simulator for GNU/Linux and OSX")
+    (synopsis "Lean, mean and hackable simulator for AVR CPUs/MCUs")
     (description
-     "simavr is a new AVR simulator for GNU/Linux, or any platform that uses
+     "simavr is a new AVR simulator for GNU/Linux or any platform that uses
 @command{avr-gcc}.  It uses avr-gcc's own register definition to simplify
 creating new targets for supported AVR devices.  The core was made to be small
 and compact, and hackable so allow quick prototyping of an AVR project.  The

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.