GNU bug report logs - #54293
[WIP] home: Add home-git-service-type

Previous Next

Package: guix-patches;

Reported by: 宋文武 <iyzsong <at> outlook.com>

Date: Mon, 7 Mar 2022 15:12:02 UTC

Severity: normal

Full log

View this message in rfc822 format

From: Maxime Devos <maximedevos <at> telenet.be>
To: iyzsong <at> outlook.com, 54293 <at> debbugs.gnu.org
Cc: 宋文武 <iyzsong <at> member.fsf.org>
Subject: [bug#54293] [PATCH v2] home: Add home-git-service-type.
Date: Sat, 12 Mar 2022 10:58:17 +0100

[Message part 1 (text/plain, inline)]
iyzsong <at> outlook.com schreef op za 12-03-2022 om 10:22 [+0800]:
> +  (user.email [...])
> +  (user.signingKey [...])
> +  (author.name [...])
> +  (author.email [...])
> +  (committer.name [...])
> +  (committer.email [...])

Conventionally (Guile) Scheme symbols are lowercase and don't use dots.
I suppose you could do 'user-signing-key'.

However, there seems to be quite some duplication between 'user',
'author' and 'committer'.  Perhaps you could abstract things a little
by e.g. doing something like the git-user-info record I proposed?

(home-git-configuration
  (user (git-user-info (name ...) (e-mail ...) (signing-key ...))
  (author user)
  (committer user)
  [other options])  

Greetings,
Maxime.


[signature.asc (application/pgp-signature, inline)]
This bug report was last modified 3 years and 24 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.