GNU bug report logs - #54245
29.0.50; select usage in GNUstep

Previous Next

Package: emacs;

Reported by: Lars Ingebrigtsen <larsi <at> gnus.org>

Date: Fri, 4 Mar 2022 15:31:01 UTC

Severity: minor

Tags: moreinfo

Found in version 29.0.50

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: 54245 <at> debbugs.gnu.org
Cc: Alan Third <alan <at> idiocy.org>
Subject: bug#54245: 29.0.50; select usage in GNUstep
Date: Fri, 04 Mar 2022 17:10:00 +0100
Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Paul noted in bug#32452 that:
>
> ---
> I notice that Emacs's GNUstep code calls 'select'. For completeness this 
> should be 'pselect' instead, so that Emacs never calls 'select'.
> ---

I guess it's this code:

- (void)fd_handler:(id)unused
/* --------------------------------------------------------------------------
     Check data waiting on file descriptors and terminate if so.
   -------------------------------------------------------------------------- */
{
[...]
          result = select (selfds[0]+1, &fds, NULL, NULL, NULL);
          if (result > 0 && read (selfds[0], &c, 1) == 1 && c == 'g')
	    waiting = 0;

nsterm.m uses pselect throughout otherwise, so I guess changing this to
pselect should be unproblematic, too?  Perhaps Alan has some comments;
added to the CCs.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




This bug report was last modified 3 years and 80 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.