GNU bug report logs - #54210
27.1; appt-add checks for bad data only at end

Previous Next

Package: emacs;

Reported by: Francesco Potortì <pot <at> potorti.it>

Date: Tue, 1 Mar 2022 13:50:02 UTC

Severity: normal

Tags: fixed

Found in version 27.1

Fixed in version 29.1

Done: Robert Pluim <rpluim <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: Francesco Potortì <pot <at> potorti.it>, 54210 <at> debbugs.gnu.org
Subject: bug#54210: 27.1; appt-add checks for bad data only at end
Date: Fri, 04 Mar 2022 00:59:02 +0100

Robert Pluim <rpluim <at> gmail.com> writes:

> How about this (I canʼt find a `read-time-of-day', unless org has one hidden
> away somewhere):

Doesn't look wrong to me.

> +                       (unless (string-match appt-time-regexp time)
> +                         (user-error "Unacceptable time-string"))

I know you just more or less copied that code from the body, but I think
this can be made a `string-match-p' test.  I think that code is just
older than the existence of `string-match-p'.

Michael.
This bug report was last modified 3 years and 43 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.