GNU bug report logs - #54210
27.1; appt-add checks for bad data only at end

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 54210 in the body.
You can then email your comments to 54210 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Francesco Potortì <pot <at> potorti.it>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.1; appt-add checks for bad data only at end
Date: Tue, 01 Mar 2022 13:54:47 +0100

appt-add asks the user for three parameters:
- time (a time string)
- message (a string)
- minutes (a number)

if the time string is badly formatted (for example if it is "8" rather than "8.00") appt-add barfs.  That's ok, but it barfs only after all three parameters have been read.  It should barf immediately after submitting the wrong parameter.

Maybe I'll find the time to look at it and propose a patch, but since I don't know, I prefer reporting it now.

Message #8 received at 54210 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Francesco Potortì <pot <at> potorti.it>
Cc: 54210 <at> debbugs.gnu.org
Subject: Re: bug#54210: 27.1; appt-add checks for bad data only at end
Date: Tue, 01 Mar 2022 15:21:57 +0100

>>>>> On Tue, 01 Mar 2022 13:54:47 +0100, Francesco Potortì <pot <at> potorti.it> said:

    Francesco> appt-add asks the user for three parameters:
    Francesco> - time (a time string)
    Francesco> - message (a string)
    Francesco> - minutes (a number)

    Francesco> if the time string is badly formatted (for example if it is "8" rather
    Francesco> than "8.00") appt-add barfs.  That's ok, but it barfs only after all
    Francesco> three parameters have been read.  It should barf immediately after
    Francesco> submitting the wrong parameter.

    Francesco> Maybe I'll find the time to look at it and propose a patch, but since
    Francesco> I don't know, I prefer reporting it now.

Aha, a learning opportunity (for me :-) )

How about this (I canʼt find a `read-time-of-day', unless org has one hidden
away somewhere):

diff --git a/lisp/calendar/appt.el b/lisp/calendar/appt.el
index ebdafb438e..6a3ea7c356 100644
--- a/lisp/calendar/appt.el
+++ b/lisp/calendar/appt.el
@@ -510,10 +510,12 @@ appt-add
 Optional argument WARNTIME is an integer (or string) giving the number
 of minutes before the appointment at which to start warning.
 The default is `appt-message-warning-time'."
-  (interactive "sTime (hh:mm[am/pm]): \nsMessage: \n\
-sMinutes before the appointment to start warning: ")
-  (unless (string-match appt-time-regexp time)
-    (user-error "Unacceptable time-string"))
+  (interactive (list (let ((time (read-string "Time (hh:mm[am/pm]): ")))
+                       (unless (string-match appt-time-regexp time)
+                         (user-error "Unacceptable time-string"))
+                       time)
+                     (read-string "Message: ")
+                     (read-string "Minutes before the appointment to start warning: ")))
   (and (stringp warntime)
        (setq warntime (unless (string-equal warntime "")
                         (string-to-number warntime))))

Message #11 received at 54210 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Francesco Potortì <pot <at> potorti.it>
Cc: 54210 <at> debbugs.gnu.org
Subject: Re: bug#54210: 27.1; appt-add checks for bad data only at end
Date: Tue, 01 Mar 2022 15:40:45 +0100

>>>>> On Tue, 01 Mar 2022 15:31:32 +0100, Francesco Potortì <pot <at> potorti.it> said:

    Francesco> It works for me!

OK, Iʼll queue it up (although Iʼm running at about one push a week at
the moment, so donʼt hold your breath).

Robert
-- 

Message #14 received at 54210 <at> debbugs.gnu.org (full text, mbox):

From: Francesco Potortì <pot <at> potorti.it>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: 54210 <at> debbugs.gnu.org
Subject: Re: bug#54210: 27.1; appt-add checks for bad data only at end
Date: Tue, 01 Mar 2022 15:31:32 +0100

>>>>>> On Tue, 01 Mar 2022 13:54:47 +0100, Francesco Potortì <pot <at> potorti.it> said:
>    Francesco> appt-add asks the user for three parameters:
>    Francesco> - time (a time string)
>    Francesco> - message (a string)
>    Francesco> - minutes (a number)
>
>    Francesco> if the time string is badly formatted (for example if it is "8" rather
>    Francesco> than "8.00") appt-add barfs.  That's ok, but it barfs only after all
>    Francesco> three parameters have been read.  It should barf immediately after
>    Francesco> submitting the wrong parameter.
>
>    Francesco> Maybe I'll find the time to look at it and propose a patch, but since
>    Francesco> I don't know, I prefer reporting it now.
>
>Aha, a learning opportunity (for me :-) )
>
>How about this (I canʼt find a `read-time-of-day', unless org has one hidden
>away somewhere):
>
>diff --git a/lisp/calendar/appt.el b/lisp/calendar/appt.el
>index ebdafb438e..6a3ea7c356 100644
>--- a/lisp/calendar/appt.el
>+++ b/lisp/calendar/appt.el
>@@ -510,10 +510,12 @@ appt-add
> Optional argument WARNTIME is an integer (or string) giving the number
> of minutes before the appointment at which to start warning.
> The default is `appt-message-warning-time'."
>-  (interactive "sTime (hh:mm[am/pm]): \nsMessage: \n\
>-sMinutes before the appointment to start warning: ")
>-  (unless (string-match appt-time-regexp time)
>-    (user-error "Unacceptable time-string"))
>+  (interactive (list (let ((time (read-string "Time (hh:mm[am/pm]): ")))
>+                       (unless (string-match appt-time-regexp time)
>+                         (user-error "Unacceptable time-string"))
>+                       time)
>+                     (read-string "Message: ")
>+                     (read-string "Minutes before the appointment to start warning: ")))
>   (and (stringp warntime)
>        (setq warntime (unless (string-equal warntime "")
>                         (string-to-number warntime))))
>

It works for me!

Message #17 received at 54210 <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: Francesco Potortì <pot <at> potorti.it>, 54210 <at> debbugs.gnu.org
Subject: Re: bug#54210: 27.1; appt-add checks for bad data only at end
Date: Fri, 04 Mar 2022 00:59:02 +0100

Robert Pluim <rpluim <at> gmail.com> writes:

> How about this (I canʼt find a `read-time-of-day', unless org has one hidden
> away somewhere):

Doesn't look wrong to me.

> +                       (unless (string-match appt-time-regexp time)
> +                         (user-error "Unacceptable time-string"))

I know you just more or less copied that code from the body, but I think
this can be made a `string-match-p' test.  I think that code is just
older than the existence of `string-match-p'.

Michael.

Message #20 received at 54210 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Francesco Potortì <pot <at> potorti.it>
Cc: 54210 <at> debbugs.gnu.org
Subject: Re: bug#54210: 27.1; appt-add checks for bad data only at end
Date: Tue, 05 Apr 2022 18:11:52 +0200

tags 54210 fixed
close 54210 29.1
quit

>>>>> On Tue, 01 Mar 2022 15:40:45 +0100, Robert Pluim <rpluim <at> gmail.com> said:

>>>>> On Tue, 01 Mar 2022 15:31:32 +0100, Francesco Potortì <pot <at> potorti.it> said:
    Francesco> It works for me!

    Robert> OK, Iʼll queue it up (although Iʼm running at about one push a week at
    Robert> the moment, so donʼt hold your breath).

Closing.
Committed as 0e9420bc8f

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.