GNU bug report logs - #54201
[PATCH] Add wego

Previous Next

Full log

Message #13 received at 54201-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 54201-done <at> debbugs.gnu.org
Subject: Re: bug#54201: [PATCH] Add wego
Date: Sat, 19 Mar 2022 00:59:09 +0100

Hello,

Ludovic Courtès <ludo <at> gnu.org> writes:

> Nicolas Goaziou <mail <at> nicolasgoaziou.fr> skribis:

>> +++ b/gnu/packages/weather.scm
>> @@ -0,0 +1,34 @@
>> +(define-module (gnu packages weather)
>
> Please add a license header.

Done.

>> +    (description "@strong{wego} is a weather client for the terminal.")
>
> Could you expound a little bit, mentioning key features, etc.?
>
> You can prolly remove @strong.

Done.

>> +    (license isc)))
>
> Perhaps #:prefix license: ?

I thought we needed to use the prefix only when there was a conflict in
the module.

Anyhow, done.

> Otherwise LGTM, thanks!

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.